diff --git a/COMMENTS.md b/COMMENTS.md new file mode 100644 index 0000000..40266fa --- /dev/null +++ b/COMMENTS.md @@ -0,0 +1,84 @@ +# Comments for Resume Formatter Final Project + +* server.js + * get rid of extra console.log() at the end if you don't need it anymore + +* README.md + * excellent, well written, very clear + +* package.json and LICENSE + * excellent, nothing missing :) + +* gulpfile.js + * good, well-organized, not too long. + * consider setting the Sass file sources on lines 28 and 37 to a variable, like you did with testFiles? + +* server_test.js + * hannah montana... :) + * good explanatory comments + * did you mean to leave that debugger on line 86? + * good tests, you went beyond the most simple things to check some other functionalities + +* auth_test.js + * good, clear, well-structured + +* resumes_controller_tests.js + * you guys are killing me with the bear names :) + +* user_routes.js + * good error messages + +* resume_routes.js + * good unobstrusive comments make it easy to navigate this file + +* user.js + * Never seen the unique-validator before! Cool! + +* resume.js + * you weren't kidding about the size of the resume model! That said, it's well organized and still readable, so nice job. + +* lib/ + * consider more informative error messages in eat_auth.js + +* index.html + * Hooray for metadata! :) + * The footer is a little div-y; I am unsure what purpose your footer-container class is serving that the footer itself, or the copyright div, couldn't take on. + * Instead of creating a class called 'main-footer', why not just apply those styles to the footer element? + * You have an unclosed `` tag in the footer, and a closing `` tag that has no partner...I would go with the `` instead of the `