♻️ Audit and start removing existing Clippy allows in orbitdock-server

[Robdel12]

Context

A prior OrbitDock session (od-ad2998ae-1d71-46cb-be7c-aee2daba045a, summary: Audit Clippy allows and policy) audited the current Rust #[allow(clippy::...)] usage across orbitdock-server.

That session found that we are relying on Clippy allows as an escape hatch in places where Clippy is actually pointing at real design problems.

The repo policy has already been tightened in AGENTS.md to say we should not add new #[allow(clippy::...)] directives without explicit approval.

Now we should start paying down the existing ones.

Findings

Current allow sites in orbitdock-server include these buckets:

• clippy::too_many_arguments — dominant category by far
• clippy::large_enum_variant
• clippy::type_complexity
• clippy::needless_return
• clippy::enum_variant_names

Representative hotspots from the audit:

• orbitdock-server/crates/connector-claude/src/lib.rs
• orbitdock-server/crates/connector-core/src/transition.rs
• orbitdock-server/crates/cli/src/commands/session.rs
• orbitdock-server/crates/server/src/connectors/codex_rollout/runtime.rs
• orbitdock-server/crates/server/src/runtime/session_commands.rs
• orbitdock-server/crates/protocol/src/client.rs
• orbitdock-server/crates/protocol/src/server.rs
• orbitdock-server/crates/server/src/infrastructure/persistence/session_reads.rs
• orbitdock-server/crates/server/src/admin/hook_forward.rs

Task

Start the Clippy cleanup by removing existing #[allow(clippy::...)] directives where the underlying design fix is straightforward, and break out follow-up issues for any larger refactors.

Use Clippy's intent as the guide:

• too_many_arguments → introduce a params/config struct or other better API shape
• large_enum_variant → box the large variant or reshape the enum
• type_complexity → add a named type alias or helper type
• needless_return → simplify the code directly
• enum_variant_names → rename or reshape the enum if it is truly worth doing

Scope

This issue should focus on:

• auditing the current allow sites
• fixing the easy / high-confidence ones directly
• identifying which remaining allow sites deserve their own follow-up issues because they imply larger API or protocol refactors

Do not add new #[allow(clippy::...)] directives as part of this work.

Deliverable

Leave a short implementation note on the issue or in a linked doc/comment that includes:

• which allow sites were removed
• which allow sites remain
• which ones were split into follow-up issues and why
• the recommended next cleanup order

Acceptance Criteria

• Existing Clippy allow sites are audited from the current codebase, not guessed.
• Straightforward allow removals are fixed by improving the code instead of re-suppressing the lint.
• Larger refactors are broken into follow-up issues rather than ballooning this issue.
• The work follows the repo policy that Clippy warnings should drive better design, not be muted by default.

Notes

This issue comes directly from the context of session od-ad2998ae-1d71-46cb-be7c-aee2daba045a.

[Robdel12]

📋 Workpad — Clippy Allow Audit & Cleanup

Audit Summary

Found 34 #[allow(clippy::...)] sites across orbitdock-server:

• too_many_arguments — 26 sites (dominant category)
• large_enum_variant — 5 sites
• type_complexity — 1 site
• needless_return — 1 site
• enum_variant_names — 1 site

Plan

Phase 1 — Easy fixes (this PR):

• needless_return in dev_console.rs — remove allow, code is already correct
• enum_variant_names in hook_forward.rs — audit if still triggers, remove if not
• type_complexity in session_reads.rs — introduce named struct for 25-element tuple
• Easy too_many_arguments — introduce params structs for:
  • transition.rs (3 functions) — ApprovalPreviewInput struct
  • codex.rs normalized_event — NormalizedEventInput struct
  • usage.rs upsert fn — TurnSnapshotRow struct
  • codex_rollout/runtime.rs handle_session_meta_event — params struct
  • CLI commands (review.rs, session.rs) — params structs
  • handle_result_message in claude connector
• Medium too_many_arguments — params structs for:
  • tool_display.rs compute_tool_display
  • prompt.rs render_prompt
  • update_work_state in codex_rollout
  • mission_control.rs update fn
  • session_resume.rs spawn fn

Phase 2 — Follow-up issues:

• large_enum_variant on ServerMessage, ClientMessage, OutboundMessage, PersistOp, SessionCommand — protocol types, wide blast radius
• Hard too_many_arguments in connector code (claude event_loop/dispatch, codex session constructors, Session::restore with 23 params)

Progress

• Audit complete
• Easy fixes
• Medium fixes
• Follow-up issues filed
• rust-ci passing
• PR created

[Robdel12]

♻️ Audit and remove 18 Clippy allows in orbitdock-server: #79

[Robdel12]

✅ Workpad — Final Summary

Results

Removed 18 of 34 #[allow(clippy::...)] directives by fixing the underlying design issues:

Category	Before	Removed	Remaining
too_many_arguments	26	15	11
large_enum_variant	5	0	5
type_complexity	1	1	0
needless_return	1	1	0
enum_variant_names	1	1	0
Total	34	18	16

Params structs introduced

ApprovalPreviewContext, ToolDisplayInput, IssueContext, NormalizedEventParams, TurnSnapshotRow, WorkStateUpdate, SessionMetaEvent, ClaudeResumeParams, MissionIssueStateUpdate, CreateReviewArgs, CreateSessionArgs, ActiveSessionRow

Follow-up issues filed

• ♻️ Box large enum variants in protocol types (ServerMessage, ClientMessage, etc.) #75 — Box large enum variants in protocol types (5 sites)
• ♻️ Refactor Claude connector internals to reduce argument counts #76 — Refactor Claude connector internals (5 sites)
• ♻️ Refactor Codex connector and session constructor argument counts #77 — Refactor Codex connector internals (4 sites)
• ♻️ Refactor Session::restore and handle_fork_session argument counts #78 — Refactor Session::restore and handle_fork_session (2 sites)

Recommended cleanup order

1. ♻️ Refactor Session::restore and handle_fork_session argument counts #78 (2 sites, self-contained)
2. ♻️ Box large enum variants in protocol types (ServerMessage, ClientMessage, etc.) #75 (5 sites, mechanical boxing)
3. ♻️ Refactor Claude connector internals to reduce argument counts #76 + ♻️ Refactor Codex connector and session constructor argument counts #77 together (9 sites, shared Arc pattern)

PR

#79 — make rust-ci passes clean