♻️ Refactor Claude connector internals to reduce argument counts

[Robdel12]

Context

Follow-up from #71 (Clippy allow audit). Five #[allow(clippy::too_many_arguments)] sites remain in the Claude connector:

• connector-claude/src/lib.rs — ClaudeConnector::new (8 params)
• connector-claude/src/lib.rs — event_loop (6 params, all Arc<Mutex>)
• connector-claude/src/lib.rs — dispatch_stdout_message (14 params — worst case in codebase)
• connector-claude/src/lib.rs — handle_assistant_message (9 params)
• connector-claude/src/session.rs — ClaudeSession::new (9 params, public API)

Why these were deferred

The Claude connector uses a shared-state pattern where multiple Arc<Mutex<>> references are passed through the event loop pipeline. Refactoring requires either:

• Introducing a ClaudeEventLoopState struct that groups the shared state (preferred)
• Or restructuring the connector to use an actor/struct with methods

ClaudeSession::new is a public API boundary — changing it requires coordinating all callers.

dispatch_stdout_message with 14 parameters is the single worst offender in the codebase and would benefit most from a state struct.

Recommended approach

1. Create ClaudeEventLoopState grouping the Arc<Mutex> fields
2. Refactor event_loop → dispatch_stdout_message → handle_assistant_message chain to pass the struct
3. Create ClaudeSessionConfig for ClaudeSession::new / ClaudeConnector::new

Acceptance Criteria

• All 5 #[allow(clippy::too_many_arguments)] in connector-claude removed
• make rust-ci passes

---

Follow-up from #71: I_kwDORFu4Vs71Vr9-

[Robdel12]

Workpad — ♻️ Refactor Claude connector internals to reduce argument counts

Plan

Goal: Remove all 5 #[allow(clippy::too_many_arguments)] in connector-claude.

Approach:

1. ClaudeSessionConfig (session.rs) — Groups CLI spawn parameters used by both ClaudeSession::new (9 params) and ClaudeConnector::new (8 params): cwd, model, resume_id, permission_mode, allowed_tools, disallowed_tools, effort, allow_bypass_permissions.

2. ClaudeEventLoopState (lib.rs) — Groups both the shared Arc refs AND mutable local state used by event_loop (6 params), dispatch_stdout_message (15 params!), and handle_assistant_message (9 params):

   • Shared: session_id, pending_controls, pending_approvals, stdin_tx
   • Mutable: streaming_content, streaming_msg_id, in_turn, turn_patch_diffs, last_turn_input, cumulative_output, last_context_window, task_tool_use_map, compacting_msg_id, tool_rows, line_count

3. Update all 7 call sites of ClaudeSession::new across 6 files to use config struct.

4. Update sub-handlers (handle_system_message, handle_assistant_message, handle_result_message, etc.) to take &mut ClaudeEventLoopState instead of individual fields.

Status: 🔧 In Progress

[Robdel12]

♻️ Refactor Claude connector internals to reduce argument counts: #81

[Robdel12]

Workpad — ♻️ Refactor Claude connector internals to reduce argument counts

Status: ✅ Complete

PR: #81

What was done

1. ClaudeSessionConfig — groups 8 CLI spawn params (cwd, model, resume_id, permission_mode, allowed_tools, disallowed_tools, effort, allow_bypass_permissions), used by both ClaudeSession::new and ClaudeConnector::new

2. ClaudeEventLoopState — groups shared Arc refs + mutable local state (15 fields total), passed through the event_loop → dispatch_stdout_message → sub-handler chain

3. All 5 #[allow(clippy::too_many_arguments)] removed:

   • ClaudeConnector::new: 8 params → 1 (config struct)
   • event_loop: 6 params → 3 (stdout, event_tx, state)
   • dispatch_stdout_message: 15 params → 2 (raw, state)
   • handle_assistant_message: 9 params → 3 (raw, session_id, state)
   • ClaudeSession::new: 9 params → 2 (session_id, config)

4. Updated all 7 call sites across 6 server files

5. make rust-ci passes clean — fmt, clippy, build, and all tests green

Net: -297 lines removed, +252 lines added (net -45 lines)

[Robdel12]

OrbitDock session od-597332fc-a8b4-43a6-af62-3e4cbfa50d94 stalled after 1009s of inactivity and was terminated.

[Robdel12]

Workpad — ♻️ Refactor Claude connector internals

Status: Ready for PR

Completed

• Created ClaudeEventLoopState struct grouping Arc<Mutex<>> shared state
• Refactored event_loop → dispatch_stdout_message → handle_assistant_message chain to pass the struct
• Created ClaudeSessionConfig for ClaudeSession::new / ClaudeConnector::new
• All 5 #[allow(clippy::too_many_arguments)] removed from connector-claude
• make rust-ci passes
• PR created and linked