Skip to content

WorkflowSettingsPanel clears pending value edits made while save is in flight #1437

Description

@gsxdsm

Found by ce-code-review run 20260605-011952-1c8655ba on branch gsxdsm/cleanupsettings (workflow settings mechanism).

Severity: P2 · Reviewer: julik-frontend-races · Confidence: 75
Location: packages/dashboard/app/components/WorkflowSettingsPanel.tsx:584

save() sends a closure snapshot of pending, but fields stay editable during the round-trip; on success setPending({}) unconditionally discards edits made mid-flight.

Suggested fix: snapshot pending at invocation and on success delete only the saved keys from pending (~10 lines).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions