-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathplugin_registry.go
More file actions
740 lines (603 loc) · 21.8 KB
/
plugin_registry.go
File metadata and controls
740 lines (603 loc) · 21.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
// plugin_registry.go: Host-side plugin registry and client management system
//
// This file implements the host-side plugin registry that manages plugin clients,
// discovery, loading, and lifecycle. It provides standard plugin
// client architecture while using generic terminology and integrating with
// the existing go-plugins infrastructure.
//
// Copyright (c) 2025 AGILira - A. Giordano
// Series: an AGILira library
// SPDX-License-Identifier: MPL-2.0
package goplugins
import (
"context"
"fmt"
"sync"
"time"
)
// PluginRegistry manages plugin clients on the host side.
//
// This is the host-side counterpart to the plugin serve interface. It handles
// plugin discovery, client creation, lifecycle management, and provides a
// unified interface for interacting with subprocess-based plugins.
//
// Key responsibilities:
// - Plugin discovery and registration
// - Client lifecycle management (start/stop/restart)
// - Health monitoring and automatic recovery
// - Request routing to appropriate plugin instances
// - Integration with existing Manager and Discovery systems
type PluginRegistry struct {
// Configuration
config RegistryConfig
logger Logger
// Plugin management
clients map[string]*PluginClient
factories map[string]PluginFactory[any, any]
clientMutex sync.RWMutex
factoryMutex sync.RWMutex
// Discovery integration
discoveryEngine *DiscoveryEngine
// Request tracking for graceful draining
requestTracker *RequestTracker
// Observability integration
observabilityConfig ObservabilityConfig
metricsCollector MetricsCollector
commonMetrics *CommonPluginMetrics
tracingProvider TracingProvider
// Lifecycle
ctx context.Context
cancel context.CancelFunc
running bool
runMutex sync.Mutex
draining bool
}
// RegistryConfig configures the plugin registry behavior.
type RegistryConfig struct {
// Plugin discovery settings
DiscoveryPaths []string `json:"discovery_paths" yaml:"discovery_paths"`
AutoDiscovery bool `json:"auto_discovery" yaml:"auto_discovery"`
DiscoveryInterval time.Duration `json:"discovery_interval" yaml:"discovery_interval"`
// Client management
MaxClients int `json:"max_clients" yaml:"max_clients"`
ClientTimeout time.Duration `json:"client_timeout" yaml:"client_timeout"`
HealthCheckConfig HealthCheckConfig `json:"health_check" yaml:"health_check"`
// Subprocess settings
HandshakeConfig HandshakeConfig `json:"handshake" yaml:"handshake"`
// Plugin type mappings
TypeMappings map[string]string `json:"type_mappings" yaml:"type_mappings"`
// Graceful draining configuration
DrainOptions DrainOptions `json:"drain_options" yaml:"drain_options"`
// Logging
Logger Logger `json:"-" yaml:"-"`
}
// RegistryStats provides overall registry statistics.
type RegistryStats struct {
TotalClients int `json:"total_clients"`
ActiveClients int `json:"active_clients"`
HealthyClients int `json:"healthy_clients"`
ClientsByType map[string]int `json:"clients_by_type"`
ClientsByStatus map[PluginStatus]int `json:"clients_by_status"`
ClientStats map[string]ClientStats `json:"client_stats"`
}
// NewPluginRegistry creates a new plugin registry.
func NewPluginRegistry(config RegistryConfig) *PluginRegistry {
setConfigDefaults(&config)
ctx, cancel := context.WithCancel(context.Background())
observabilityConfig, metricsCollector, commonMetrics := initializeObservability()
return &PluginRegistry{
config: config,
logger: config.Logger,
clients: make(map[string]*PluginClient),
factories: make(map[string]PluginFactory[any, any]),
requestTracker: NewRequestTrackerWithObservability(metricsCollector, observabilityConfig.MetricsPrefix),
observabilityConfig: observabilityConfig,
metricsCollector: metricsCollector,
commonMetrics: commonMetrics,
tracingProvider: observabilityConfig.TracingProvider,
ctx: ctx,
cancel: cancel,
}
}
// setConfigDefaults sets default values for unspecified config fields.
func setConfigDefaults(config *RegistryConfig) {
if config.Logger == nil {
config.Logger = DefaultLogger()
}
if config.MaxClients == 0 {
config.MaxClients = 100
}
if config.ClientTimeout == 0 {
config.ClientTimeout = 30 * time.Second
}
if config.DiscoveryInterval == 0 {
config.DiscoveryInterval = 60 * time.Second
}
if config.DrainOptions.DrainTimeout == 0 {
config.DrainOptions.DrainTimeout = 30 * time.Second
}
}
// initializeObservability initializes observability components with default configuration.
func initializeObservability() (ObservabilityConfig, MetricsCollector, *CommonPluginMetrics) {
observabilityConfig := DefaultObservabilityConfig()
metricsCollector := observabilityConfig.MetricsCollector
// Create common metrics if advanced features are supported
var commonMetrics *CommonPluginMetrics
if metricsCollector.CounterWithLabels("test", "test") != nil {
commonMetrics = CreateCommonPluginMetrics(metricsCollector)
}
return observabilityConfig, metricsCollector, commonMetrics
}
// Start initializes the plugin registry and begins discovery.
func (pr *PluginRegistry) Start() error {
pr.runMutex.Lock()
defer pr.runMutex.Unlock()
if pr.running {
return NewRegistryError("plugin registry is already running", nil)
}
pr.logger.Info("Starting plugin registry",
"max_clients", pr.config.MaxClients,
"auto_discovery", pr.config.AutoDiscovery)
// Initialize discovery engine if auto-discovery is enabled
if pr.config.AutoDiscovery {
if err := pr.initializeDiscovery(); err != nil {
return NewDiscoveryError("failed to initialize discovery", err)
}
}
// Initialize factory registration
if err := pr.initializeFactories(); err != nil {
return NewFactoryError("", "failed to initialize factories", err)
}
pr.running = true
pr.logger.Info("Plugin registry started successfully")
return nil
}
// Stop gracefully shuts down the plugin registry.
func (pr *PluginRegistry) Stop() error {
return pr.StopWithContext(context.Background())
}
// StopWithContext gracefully shuts down the plugin registry with context for timeout control.
func (pr *PluginRegistry) StopWithContext(ctx context.Context) error {
pr.runMutex.Lock()
defer pr.runMutex.Unlock()
if !pr.running {
return nil
}
pr.logger.Info("Stopping plugin registry")
// Begin graceful shutdown phase
pr.draining = true
pr.cancel()
// Perform graceful draining and stop all clients
var allErrors []error
allErrors = append(allErrors, pr.performGracefulDraining(ctx)...)
allErrors = append(allErrors, pr.stopAllClients()...)
// Stop discovery engine (no explicit stop method needed)
if pr.discoveryEngine != nil {
pr.logger.Info("Discovery engine stopped")
}
pr.running = false
pr.draining = false
return pr.handleShutdownErrors(allErrors)
}
// stopAllClients stops all registered clients and returns any errors.
func (pr *PluginRegistry) stopAllClients() []error {
pr.clientMutex.Lock()
defer pr.clientMutex.Unlock()
var errors []error
for id, client := range pr.clients {
if err := client.Stop(); err != nil {
errors = append(errors, NewClientError(id, "failed to stop client", err))
}
}
return errors
}
// handleShutdownErrors processes shutdown errors and returns appropriate error or nil.
func (pr *PluginRegistry) handleShutdownErrors(errors []error) error {
if len(errors) > 0 {
return NewRegistryError(fmt.Sprintf("errors during registry shutdown: %v", errors), nil)
}
pr.logger.Info("Plugin registry stopped successfully")
return nil
}
// RegisterFactory registers a plugin factory for a specific type.
func (pr *PluginRegistry) RegisterFactory(pluginType string, factory PluginFactory[any, any]) error {
pr.factoryMutex.Lock()
defer pr.factoryMutex.Unlock()
if _, exists := pr.factories[pluginType]; exists {
return NewFactoryError(pluginType, "factory for type already registered", nil)
}
pr.factories[pluginType] = factory
pr.logger.Info("Registered plugin factory", "type", pluginType)
// Record factory registration metrics
pr.recordFactoryMetrics("register", pluginType)
return nil
}
// CreateClient creates a new plugin client.
func (pr *PluginRegistry) CreateClient(config PluginConfig) (*PluginClient, error) {
pr.clientMutex.Lock()
defer pr.clientMutex.Unlock()
// Check client limits
if len(pr.clients) >= pr.config.MaxClients {
return nil, NewRegistryError(fmt.Sprintf("maximum number of clients (%d) reached", pr.config.MaxClients), nil)
}
// Check if client already exists
if _, exists := pr.clients[config.Name]; exists {
return nil, NewClientError(config.Name, "client with name already exists", nil)
}
// Create client
client, err := pr.createClientInstance(config)
if err != nil {
return nil, NewClientError("", "failed to create client instance", err)
}
// Register client
pr.clients[config.Name] = client
clientCount := len(pr.clients)
// Record client creation metrics
pr.recordClientMetrics("create", config.Name, config.Type)
pr.logger.Info("Created plugin client",
"name", config.Name,
"type", config.Type,
"transport", config.Transport)
// Update client count gauge after releasing the lock
defer func() {
pr.updateClientCountGaugeWithCount(clientCount)
}()
return client, nil
}
// GetClient retrieves a plugin client by name.
func (pr *PluginRegistry) GetClient(name string) (*PluginClient, error) {
pr.clientMutex.RLock()
defer pr.clientMutex.RUnlock()
client, exists := pr.clients[name]
if !exists {
return nil, NewClientError(name, "client not found", nil)
}
return client, nil
}
// ListClients returns all registered clients.
func (pr *PluginRegistry) ListClients() map[string]*PluginClient {
pr.clientMutex.RLock()
defer pr.clientMutex.RUnlock()
clients := make(map[string]*PluginClient, len(pr.clients))
for name, client := range pr.clients {
clients[name] = client
}
return clients
}
// RemoveClient removes a plugin client.
func (pr *PluginRegistry) RemoveClient(name string) error {
pr.clientMutex.Lock()
defer pr.clientMutex.Unlock()
client, exists := pr.clients[name]
if !exists {
return NewClientError(name, "client not found", nil)
}
// Stop the client
if err := client.Stop(); err != nil {
pr.logger.Warn("Error stopping client during removal",
"name", name,
"error", err)
}
// Remove from registry
clientType := client.Type
delete(pr.clients, name)
// Record client removal metrics
pr.recordClientMetrics("remove", name, clientType)
pr.logger.Info("Removed plugin client", "name", name)
return nil
}
// GetStats returns registry statistics.
func (pr *PluginRegistry) GetStats() RegistryStats {
pr.clientMutex.RLock()
defer pr.clientMutex.RUnlock()
stats := RegistryStats{
TotalClients: len(pr.clients),
ClientsByType: make(map[string]int),
ClientsByStatus: make(map[PluginStatus]int),
ClientStats: make(map[string]ClientStats),
}
for name, client := range pr.clients {
client.mutex.RLock()
// Count by type
stats.ClientsByType[client.Type]++
// Count by status
stats.ClientsByStatus[client.status]++
// Collect client stats
clientStats := ClientStats{
Status: client.status,
StartTime: client.startTime,
LastPing: client.lastPing,
}
if !client.startTime.IsZero() {
clientStats.Uptime = time.Since(client.startTime)
}
stats.ClientStats[name] = clientStats
// Count active and healthy
if client.status != StatusOffline {
stats.ActiveClients++
}
if client.status == StatusHealthy {
stats.HealthyClients++
}
client.mutex.RUnlock()
}
return stats
}
// performGracefulDraining performs graceful draining on all active clients.
func (pr *PluginRegistry) performGracefulDraining(ctx context.Context) []error {
var drainErrors []error
// Get list of clients to drain
pr.clientMutex.RLock()
clientNames := make([]string, 0, len(pr.clients))
for name := range pr.clients {
clientNames = append(clientNames, name)
}
pr.clientMutex.RUnlock()
pr.logger.Info("Starting graceful draining", "clients", len(clientNames))
// Drain each client
for _, clientName := range clientNames {
activeRequests := pr.requestTracker.GetActiveRequestCount(clientName)
if activeRequests > 0 {
pr.logger.Info("Draining client",
"client", clientName,
"active_requests", activeRequests)
// Create drain options with progress callback
drainOptions := pr.config.DrainOptions
drainOptions.ProgressCallback = func(pluginName string, activeCount int64) {
pr.logger.Info("Drain progress",
"client", pluginName,
"remaining_requests", activeCount)
}
// Use context timeout for draining if provided
if deadline, ok := ctx.Deadline(); ok {
// Reduce drain timeout to fit within context deadline
remaining := time.Until(deadline)
if remaining < drainOptions.DrainTimeout {
drainOptions.DrainTimeout = remaining
}
}
if err := pr.requestTracker.GracefulDrain(clientName, drainOptions); err != nil {
drainErrors = append(drainErrors, NewClientError(clientName, "failed to drain client", err))
} else {
pr.logger.Info("Client drained successfully", "client", clientName)
}
}
}
if len(drainErrors) == 0 {
pr.logger.Info("All clients drained successfully")
} else {
pr.logger.Warn("Some clients failed to drain gracefully", "errors", len(drainErrors))
}
return drainErrors
}
// StartDraining begins the draining process without stopping the registry.
// This allows new requests to be rejected while existing ones complete.
func (pr *PluginRegistry) StartDraining() error {
pr.runMutex.Lock()
defer pr.runMutex.Unlock()
if !pr.running {
return NewRegistryError("registry is not running", nil)
}
if pr.draining {
return NewRegistryError("registry is already draining", nil)
}
pr.logger.Info("Starting registry draining mode")
pr.draining = true
return nil
}
// IsDraining returns true if the registry is in draining mode.
func (pr *PluginRegistry) IsDraining() bool {
pr.runMutex.Lock()
defer pr.runMutex.Unlock()
return pr.draining
}
// GetActiveRequestsCount returns the total number of active requests across all clients.
func (pr *PluginRegistry) GetActiveRequestsCount() map[string]int64 {
return pr.requestTracker.GetAllActiveRequests()
}
// CallClient makes a tracked method call to a specific plugin client.
// This method automatically handles request tracking for graceful draining.
func (pr *PluginRegistry) CallClient(ctx context.Context, clientName, method string, args interface{}) (interface{}, error) {
// Check if registry is draining - reject new requests
if pr.IsDraining() {
return nil, NewRegistryError("registry is draining, not accepting new requests", nil)
}
client, err := pr.GetClient(clientName)
if err != nil {
return nil, err
}
return client.Call(ctx, method, args, pr.requestTracker)
}
// CallClientAsync makes an asynchronous tracked method call to a specific plugin client.
// Returns a channel that will receive the result or error.
func (pr *PluginRegistry) CallClientAsync(ctx context.Context, clientName, method string, args interface{}) (<-chan AsyncResult, error) {
// Check if registry is draining - reject new requests
if pr.IsDraining() {
return nil, NewRegistryError("registry is draining, not accepting new requests", nil)
}
client, err := pr.GetClient(clientName)
if err != nil {
return nil, err
}
resultChan := make(chan AsyncResult, 1)
go func() {
defer close(resultChan)
result, err := client.Call(ctx, method, args, pr.requestTracker)
resultChan <- AsyncResult{
Result: result,
Error: err,
}
}()
return resultChan, nil
}
// AsyncResult represents the result of an asynchronous call.
type AsyncResult struct {
Result interface{}
Error error
}
// initializeDiscovery sets up the discovery engine.
func (pr *PluginRegistry) initializeDiscovery() error {
if len(pr.config.DiscoveryPaths) == 0 {
pr.logger.Warn("No discovery paths configured, skipping auto-discovery")
return nil
}
discoveryConfig := pr.createDiscoveryConfig()
engine := NewDiscoveryEngine(discoveryConfig, pr.logger)
pr.discoveryEngine = engine
pr.logger.Info("Discovery engine initialized",
"paths", pr.config.DiscoveryPaths,
"interval", pr.config.DiscoveryInterval)
return nil
}
// createDiscoveryConfig creates discovery configuration with sensible defaults.
func (pr *PluginRegistry) createDiscoveryConfig() ExtendedDiscoveryConfig {
defaultPatterns := []string{"*.so", "plugin-*", "*-plugin"}
defaultFilePatterns := append(defaultPatterns, "*.exe")
return ExtendedDiscoveryConfig{
DiscoveryConfig: DiscoveryConfig{
Enabled: true,
Directories: pr.config.DiscoveryPaths,
Patterns: defaultPatterns,
WatchMode: true,
},
SearchPaths: pr.config.DiscoveryPaths,
FilePatterns: defaultFilePatterns,
MaxDepth: 3,
FollowSymlinks: false,
AllowedTransports: []TransportType{TransportExecutable},
ValidateManifests: true,
RequiredCapabilities: []string{},
ExcludePaths: []string{},
DiscoveryTimeout: pr.config.DiscoveryInterval,
}
}
// initializeFactories sets up the factory registration.
func (pr *PluginRegistry) initializeFactories() error {
// Register subprocess factory
subprocessFactory := NewSubprocessPluginFactory[any, any](pr.logger)
if err := pr.RegisterFactory("subprocess", subprocessFactory); err != nil {
return NewFactoryError("subprocess", "failed to register subprocess factory", err)
}
pr.logger.Info("Factory registration initialized")
return nil
}
// createClientInstance creates a new plugin client instance.
func (pr *PluginRegistry) createClientInstance(config PluginConfig) (*PluginClient, error) {
ctx, cancel := context.WithCancel(pr.ctx)
client := &PluginClient{
ID: fmt.Sprintf("%s-%d", config.Name, time.Now().UnixNano()),
Name: config.Name,
Type: config.Type,
config: config,
ctx: ctx,
cancel: cancel,
logger: pr.logger,
status: StatusOffline,
}
// Set executable and args for subprocess plugins
if config.Transport == TransportExecutable {
client.executable = config.Executable
client.args = config.Args
}
// Initialize health checker if enabled
if pr.config.HealthCheckConfig.Enabled {
client.healthChecker = NewHealthChecker(client, pr.config.HealthCheckConfig)
}
return client, nil
}
// Observability methods for PluginRegistry
// ConfigureObservability configures comprehensive observability for the plugin registry
func (pr *PluginRegistry) ConfigureObservability(config ObservabilityConfig) error {
pr.clientMutex.Lock()
defer pr.clientMutex.Unlock()
pr.observabilityConfig = config
pr.metricsCollector = config.MetricsCollector
pr.tracingProvider = config.TracingProvider
// Create common metrics if advanced features are available
if config.MetricsCollector.CounterWithLabels("test", "test") != nil {
pr.commonMetrics = CreateCommonPluginMetrics(config.MetricsCollector)
}
pr.logger.Info("Plugin registry observability configured",
"level", string(config.Level),
"metrics_enabled", config.IsMetricsEnabled(),
"tracing_enabled", config.IsTracingEnabled(),
"logging_enabled", config.IsLoggingEnabled())
return nil
}
// recordMetrics is a helper method to record metrics with labels
func (pr *PluginRegistry) recordMetrics(metricName string, labels map[string]string) {
if !pr.observabilityConfig.IsMetricsEnabled() || pr.metricsCollector == nil {
return
}
pr.metricsCollector.IncrementCounter(
pr.observabilityConfig.MetricsPrefix+"_"+metricName,
labels,
1,
)
}
// recordFactoryMetrics records plugin factory operations
func (pr *PluginRegistry) recordFactoryMetrics(operation, pluginType string) {
pr.recordMetrics("plugin_factory_operations_total", map[string]string{
"operation": operation,
"plugin_type": pluginType,
})
}
// recordClientMetrics records client lifecycle operations
func (pr *PluginRegistry) recordClientMetrics(operation, clientName, clientType string) {
pr.recordMetrics("plugin_client_operations_total", map[string]string{
"operation": operation,
"client_name": clientName,
"client_type": clientType,
})
}
// updateClientCountGaugeWithCount updates the gauge with the provided count (no additional locking)
func (pr *PluginRegistry) updateClientCountGaugeWithCount(count int) {
if !pr.observabilityConfig.IsMetricsEnabled() || pr.metricsCollector == nil {
return
}
pr.metricsCollector.SetGauge(
pr.observabilityConfig.MetricsPrefix+"_plugin_clients_active",
map[string]string{},
float64(count),
)
}
// GetObservabilityMetrics returns comprehensive observability metrics from the registry
func (pr *PluginRegistry) GetObservabilityMetrics() map[string]interface{} {
pr.clientMutex.RLock()
pr.factoryMutex.RLock()
defer pr.clientMutex.RUnlock()
defer pr.factoryMutex.RUnlock()
metrics := make(map[string]interface{})
// Client metrics
clientsByType := make(map[string]int)
clientsByStatus := make(map[string]int)
for _, client := range pr.clients {
clientsByType[client.Type]++
clientsByStatus[client.status.String()]++
}
metrics["registry"] = map[string]interface{}{
"total_clients": len(pr.clients),
"max_clients": pr.config.MaxClients,
"clients_by_type": clientsByType,
"clients_by_status": clientsByStatus,
"factory_count": len(pr.factories),
"is_running": pr.running,
"is_draining": pr.draining,
}
// Get metrics from collector if available
if pr.metricsCollector != nil {
metrics["collector"] = pr.metricsCollector.GetMetrics()
}
// Get Prometheus metrics if available
if pr.commonMetrics != nil && pr.observabilityConfig.MetricsCollector != nil {
if prometheusMetrics := pr.observabilityConfig.MetricsCollector.GetPrometheusMetrics(); prometheusMetrics != nil {
metrics["prometheus"] = prometheusMetrics
}
}
return metrics
}
// EnableObservability is a convenience method to enable observability with default settings
func (pr *PluginRegistry) EnableObservability() error {
config := DefaultObservabilityConfig()
return pr.ConfigureObservability(config)
}