Skip to content

Commit cc9232c

Browse files
committed
Fix spec update
1 parent 8de3c59 commit cc9232c

5 files changed

Lines changed: 14 additions & 10 deletions

File tree

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfig.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.sap.ai.sdk.orchestration.model.InputFilteringConfig;
77
import com.sap.ai.sdk.orchestration.model.LLMModelDetails;
88
import com.sap.ai.sdk.orchestration.model.MaskingModuleConfig;
9+
import com.sap.ai.sdk.orchestration.model.MaskingModuleConfigProviders;
910
import com.sap.ai.sdk.orchestration.model.OutputFilteringConfig;
1011
import com.sap.ai.sdk.orchestration.model.PromptTemplatingModuleConfigPrompt;
1112
import com.sap.ai.sdk.orchestration.model.SAPDocumentTranslation;
@@ -130,9 +131,9 @@ public OrchestrationModuleConfig withMaskingConfig(
130131
@Nonnull final MaskingProvider maskingProvider,
131132
@Nonnull final MaskingProvider... maskingProviders) {
132133
val newMaskingConfig =
133-
MaskingModuleConfig.create().maskingProviders(maskingProvider.createConfig());
134+
MaskingModuleConfigProviders.create().providers(maskingProvider.createConfig());
134135
Arrays.stream(maskingProviders)
135-
.forEach(it -> newMaskingConfig.addMaskingProvidersItem(it.createConfig()));
136+
.forEach(it -> newMaskingConfig.addProvidersItem(it.createConfig()));
136137

137138
return withMaskingConfig(newMaskingConfig);
138139
}

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfigTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import com.sap.ai.sdk.orchestration.model.DocumentGroundingFilter;
1616
import com.sap.ai.sdk.orchestration.model.GroundingModuleConfigConfig;
1717
import com.sap.ai.sdk.orchestration.model.GroundingModuleConfigConfigFiltersInner;
18+
import com.sap.ai.sdk.orchestration.model.MaskingModuleConfigProviders;
1819
import com.sap.ai.sdk.orchestration.model.ResponseFormatJsonObject;
1920
import com.sap.ai.sdk.orchestration.model.ResponseFormatJsonSchema;
2021
import com.sap.ai.sdk.orchestration.model.Template;
@@ -87,8 +88,10 @@ void testDpiMaskingConfig() {
8788
new OrchestrationModuleConfig().withLlmConfig(GPT_4O).withMaskingConfig(maskingConfig);
8889

8990
assertThat(config.getMaskingConfig()).isNotNull();
90-
assertThat(config.getMaskingConfig().getMaskingProviders()).hasSize(1);
91-
DPIConfig dpiConfig = config.getMaskingConfig().getMaskingProviders().get(0);
91+
assertThat(((MaskingModuleConfigProviders) config.getMaskingConfig()).getProviders())
92+
.hasSize(1);
93+
DPIConfig dpiConfig =
94+
((MaskingModuleConfigProviders) config.getMaskingConfig()).getProviders().get(0);
9295
assertThat(dpiConfig.getMethod()).isEqualTo(DPIConfig.MethodEnum.ANONYMIZATION);
9396
assertThat(dpiConfig.getEntities()).hasSize(1);
9497
assertThat(((DPIStandardEntity) dpiConfig.getEntities().get(0)).getType())
@@ -98,7 +101,7 @@ void testDpiMaskingConfig() {
98101

99102
var configModified = config.withMaskingConfig(maskingConfig);
100103
assertThat(configModified.getMaskingConfig()).isNotNull();
101-
assertThat(configModified.getMaskingConfig().getMaskingProviders())
104+
assertThat(((MaskingModuleConfigProviders) configModified.getMaskingConfig()).getProviders())
102105
.withFailMessage("withMaskingConfig() should overwrite the existing config and not append")
103106
.hasSize(1);
104107
}

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
import com.sap.ai.sdk.orchestration.model.GroundingModuleConfigConfigPlaceholders;
6767
import com.sap.ai.sdk.orchestration.model.KeyValueListPair;
6868
import com.sap.ai.sdk.orchestration.model.LlamaGuard38b;
69-
import com.sap.ai.sdk.orchestration.model.MaskingModuleConfig;
69+
import com.sap.ai.sdk.orchestration.model.MaskingModuleConfigProviders;
7070
import com.sap.ai.sdk.orchestration.model.ModuleResultsStreaming;
7171
import com.sap.ai.sdk.orchestration.model.ResponseFormatText;
7272
import com.sap.ai.sdk.orchestration.model.SearchDocumentKeyValueListPair;
@@ -1329,7 +1329,7 @@ void testEmbeddingCallWithMasking() {
13291329
.type(DPIConfig.TypeEnum.SAP_DATA_PRIVACY_INTEGRATION)
13301330
.method(DPIConfig.MethodEnum.ANONYMIZATION)
13311331
.entities(List.of(DPIStandardEntity.create().type(DPIEntities.PERSON)));
1332-
val maskingConfig = MaskingModuleConfig.create().maskingProviders(List.of(dpiConfig));
1332+
val maskingConfig = MaskingModuleConfigProviders.create().providers(List.of(dpiConfig));
13331333

13341334
val modelParams =
13351335
EmbeddingsModelParams.create()
@@ -1408,7 +1408,7 @@ void testEmbeddingCallWithMasking() {
14081408
}
14091409
},
14101410
"masking": {
1411-
"masking_providers": [
1411+
"providers": [
14121412
{
14131413
"type": "sap_data_privacy_integration",
14141414
"method": "anonymization",

orchestration/src/test/resources/groundingRequest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
}
2727
},
2828
"masking": {
29-
"masking_providers": [
29+
"providers": [
3030
{
3131
"type": "sap_data_privacy_integration",
3232
"method": "anonymization",

orchestration/src/test/resources/maskingRequest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
}
2727
},
2828
"masking": {
29-
"masking_providers": [
29+
"providers": [
3030
{
3131
"type": "sap_data_privacy_integration",
3232
"method": "pseudonymization",

0 commit comments

Comments
 (0)