Skip to content

Bug: Launching Sub Generators crashes when first folder in workspace is virtual file system (e.g. ABAP) #937

@longieirl

Description

@longieirl

Description

Issue found when testing; https://github.wdf.sap.corp/ux-engineering/tools-suite/issues/37078

Sub generators crash when ABAP virtual folder is first in workspace.

Currently, the generator is failing when this line of code is called;

await commands.executeCommand('loadYeomanUI', {
                    generator: `@sap/fiori:${subGenerator}`,
                    messages: {
                        generators_loading,
                        panel_title,
                        yeoman_ui_title,
                        channel_name: 'Adaptation Project',
                        artifact_generated_files
                    },
                    data: {
                        path
                    }
                });

During the initial implementation of the bug, all calls to loadYeomanUI need to be wrapped, to ensure there is a valid path set before the yeoman UI is loaded. Another PR was generated to cover this flow;

https://github.wdf.sap.corp/ux-engineering/tools-suite/pull/37103

However, launching the Application Wizard directly and choosing the Fiori generator is not covered since the yeoman generator is being triggered directly;

handle this https://github.com/SAP/yeoman-ui/blob/master/packages/backend/src/yeomanui.ts#L368

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create a workspace file with the content :
{
	"folders": [
		{
			"name": "UIA_000_DEVINEA_EN",
			"uri": "abap:/repotree-v1/UIA_000_DEVINEA_EN"
		}
	]
}
  1. Open the workspace and try to launch the command "Download ADT Deployed App from SAPUI5 ABAP Repository"
  2. yeomanui crashes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions