|
1 | | -# Pull Request Template |
2 | | - |
3 | 1 | ## Description |
4 | 2 |
|
5 | | -Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. |
| 3 | +Brief summary of the change and its motivation. |
6 | 4 |
|
7 | 5 | Fixes # (issue) |
8 | 6 |
|
9 | 7 | ## Type of change |
10 | 8 |
|
11 | | -Please delete options that are not relevant. |
12 | | - |
13 | 9 | - [ ] Bug fix (non-breaking change which fixes an issue) |
14 | 10 | - [ ] New feature (non-breaking change which adds functionality) |
15 | 11 | - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) |
16 | | -- [ ] This change requires a documentation update |
| 12 | +- [ ] CFDI version support (new complement, addenda, or catalog update) |
| 13 | +- [ ] PAC integration (new or updated provider) |
| 14 | +- [ ] Documentation update |
| 15 | + |
| 16 | +## CFDI / SAT impact |
| 17 | + |
| 18 | +<!-- Delete this section if not applicable --> |
17 | 19 |
|
18 | | -## How Has This Been Tested? |
| 20 | +- **Affected CFDI versions**: (e.g., 4.0, 3.3, Retenciones 2.0) |
| 21 | +- **Affected complements**: (e.g., Nomina, Pagos, TimbreFiscalDigital) |
| 22 | +- **SAT catalog changes**: Yes / No |
19 | 23 |
|
20 | | -Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration |
| 24 | +## How has this been tested? |
21 | 25 |
|
22 | | -- [ ] Test A |
23 | | -- [ ] Test B |
| 26 | +- [ ] `pytest tests/` passes locally |
| 27 | +- [ ] Tested with sample XML files |
| 28 | +- [ ] Verified PDF/HTML rendering output |
24 | 29 |
|
25 | | -**Test Configuration**: |
26 | | -* Firmware version: |
27 | | -* Hardware: |
28 | | -* Toolchain: |
29 | | -* SDK: |
| 30 | +**Python version(s) tested**: (e.g., 3.11, 3.13) |
30 | 31 |
|
31 | | -## Checklist: |
| 32 | +## Checklist |
32 | 33 |
|
33 | | -- [ ] My code follows the style guidelines of this project |
34 | | -- [ ] I have performed a self-review of my own code |
35 | | -- [ ] I have commented my code, particularly in hard-to-understand areas |
36 | | -- [ ] I have made corresponding changes to the documentation |
37 | | -- [ ] My changes generate no new warnings |
38 | | -- [ ] I have added tests that prove my fix is effective or that my feature works |
39 | | -- [ ] New and existing unit tests pass locally with my changes |
40 | | -- [ ] Any dependent changes have been merged and published in downstream modules |
41 | | -- [ ] I have checked my code and corrected any misspellings |
| 34 | +- [ ] I have performed a self-review of my code |
| 35 | +- [ ] XML output matches SAT schema requirements (if applicable) |
| 36 | +- [ ] New and existing tests pass locally |
| 37 | +- [ ] I have updated documentation (if applicable) |
0 commit comments