enable inactive cantons when called from checker (#146)

Author: monodo

src/drillapi/routes/checker.py

@@ -72,6 +72,7 @@ async def checker_page(request: Request, canton: str | None = None):
                     request=request,
                     coord_x=x,
                     coord_y=y,
+                    exclude_inactive_cantons=False,
                 )
 
                 calculated = (

src/drillapi/routes/drill_category.py

@@ -1,4 +1,4 @@
-from fastapi import APIRouter, Request, Path
+from fastapi import APIRouter, Request, Query, Path
 from drillapi.cantons_configuration import cantons
 from ..services import processing, security
 from ..services.error_handler import handle_errors
@@ -20,6 +20,11 @@ async def get_drill_category(
     request: Request,
     coord_x: float = Path(..., gt=2400000, le=2900000),
     coord_y: float = Path(..., gt=1070000, le=1300000),
+    exclude_inactive_cantons: bool = Query(
+        True,
+        alias="exclude-inactive-cantons",
+        description="If false, inactive cantons are also used.",
+    ),
 ):
     """Return drill category at a given coordinate using WMS GetFeatureInfo or ESRI REST feature service."""
 
@@ -47,36 +52,27 @@ async def get_drill_category(
     code_canton = canton_result[0]["attributes"]["ak"]
     canton_config = cantons.CANTONS["cantons_configurations"].get(code_canton)
 
-    if not canton_config or not canton_config["active"]:
-        logger.warning(
-            "No configuration for canton %s at (%s, %s) or inactive canton",
-            code_canton,
-            coord_x,
-            coord_y,
-        )
-        suitability_feature.ground_category.harmonized_value = 5
-        suitability_feature.result_detail.message = "Canton not active"
-        suitability_feature.canton = code_canton
-        suitability_feature.canton_config = canton_config
-        return suitability_feature
-
-    # Fill canton data
     suitability_feature.canton = code_canton
     suitability_feature.canton_config = canton_config
 
-    if not canton_config["active"]:
-        logger.error(
-            "No configuration for canton %s at (%s, %s)",
+    is_missing_config = canton_config is None
+    is_active = canton_config.get("active", False) if canton_config else False
+
+    # Exclude inactive or missing cantons
+    # Inactive cantons are activated when called from checker in order to help debug network issues
+    if exclude_inactive_cantons and (is_missing_config or not is_active):
+        logger.warning(
+            "No configuration for canton %s at (%s, %s) or inactive canton",
             code_canton,
             coord_x,
             coord_y,
         )
-        suitability_feature.result_detail.message = (
-            "No configuration available for this canton."
-        )
+
+        suitability_feature.ground_category.harmonized_value = 5
+        suitability_feature.result_detail.message = "Canton not active or not existing"
         return suitability_feature
 
-    # Fetch features (WMS or ESRI REST) and process into feature
+    # Fetch features (WMS or ESRI REST) from external geoservices and process into feature
     result = await processing.fetch_features_for_point(coord_x, coord_y, canton_config)
 
     # Feature(s) found, process to reclassification