feat(vscode): returning load errors to diagnostics

[ci skip]

Author: benfdking

examples/sushi/models/customer_revenue_by_day.sql

@@ -6,9 +6,11 @@ MODEL (
     batch_size 10,
   ),
   owner jen,
+  owners test,
   cron '@daily',
   dialect hive,
   tags expensive,
+  tag sadf,
   grain (customer_id, event_date),
 );
 

sqlmesh/core/model/common.py

@@ -265,6 +265,7 @@ def validate_extra_and_required_fields(
     klass: t.Type[PydanticModel],
     provided_fields: t.Set[str],
     entity_name: str,
+    path: t.Optional[Path] = None,
 ) -> None:
     missing_required_fields = klass.missing_required_fields(provided_fields)
     if missing_required_fields:
@@ -293,7 +294,8 @@ def validate_extra_and_required_fields(
             similar_msg = "\n\n  " + "\n  ".join(similar) if similar else ""
 
         raise_config_error(
-            f"Invalid field name{'s' if len(extra_fields) > 1 else ''} present in the {entity_name}: {extra_field_names}{similar_msg}"
+            f"Invalid field name{'s' if len(extra_fields) > 1 else ''} present in the {entity_name}: {extra_field_names}{similar_msg}",
+            path,
         )
 
 

sqlmesh/core/model/definition.py

@@ -2434,7 +2434,10 @@ def _create_model(
     **kwargs: t.Any,
 ) -> Model:
     validate_extra_and_required_fields(
-        klass, {"name", *kwargs} - {"grain", "table_properties"}, "MODEL block"
+        klass,
+        {"name", *kwargs} - {"grain", "table_properties"},
+        "MODEL block",
+        path,
     )
 
     for prop in PROPERTIES:

sqlmesh/lsp/main.py

@@ -287,7 +287,8 @@ def _reload_context_and_publish_diagnostics(
             ),
         )
 
-        # Only publish diagnostics if client doesn't support pull diagnostics
+        # Only publish diagnostics if the client doesn't support pull
+        # diagnostics
         if not self.client_supports_pull_diagnostics:
             diagnostics = self.context_state.lsp_context.lint_model(uri)
             ls.publish_diagnostics(
@@ -869,15 +870,15 @@ def _create_lsp_context(
             # Only show the error message once
             if not self.has_raised_loading_error:
                 self.server.show_message(
-                    f"Error creating context: {e}",
+                    f"Error creating context error type {type(e)}: {e.location} {e}",
                     types.MessageType.Error,
                 )
                 self.has_raised_loading_error = True
-            self.server.log_trace(f"Error creating context: {e}")
             error_message = e if isinstance(e, ConfigError) else str(e)
-            if isinstance(error_message, ConfigError) and error_message.location is not None:
+            if isinstance(e, ConfigError) and error_message.location is not None:
+                self.server.show_message("hello", types.MessageType.Error)
                 uri = URI.from_path(error_message.location)
-                ls.publish_diagnostics(
+                self.server.publish_diagnostics(
                     uri.value,
                     [
                         types.Diagnostic(
@@ -889,6 +890,7 @@ def _create_lsp_context(
                             severity=types.DiagnosticSeverity.Error,
                         )
                     ],
+                str(1),
                 )
 
             # Store the error in context state such that later requests can