Fix: Add tests that validate correctness of data previews in dev for models which only support full history restatement (#2740)

Author: izeigerman

sqlmesh/core/plan/builder.py

@@ -644,7 +644,7 @@ def _apply_effective_from(self) -> None:
                 raise PlanError("Effective date cannot be in the future.")
 
         for snapshot in self._context_diff.new_snapshots.values():
-            if not snapshot.disable_restatement:
+            if not snapshot.disable_restatement and not snapshot.full_history_restatement_only:
                 snapshot.effective_from = self._effective_from
 
     def _is_forward_only_change(self, s_id: SnapshotId) -> bool:

tests/core/test_integration.py

@@ -335,6 +335,66 @@ def test_forward_only_model_regular_plan_preview_enabled(init_and_plan_context:
     assert dev_df["event_date"].tolist() == [pd.to_datetime("2023-01-07")]
 
 
+@freeze_time("2023-01-08 15:00:00")
+def test_full_history_restatement_model_regular_plan_preview_enabled(
+    init_and_plan_context: t.Callable,
+):
+    context, plan = init_and_plan_context("examples/sushi")
+    context.apply(plan)
+
+    model_name = "sushi.marketing"  # SCD2 model
+
+    model = context.get_model(model_name)
+    model = add_projection_to_model(t.cast(SqlModel, model))
+
+    context.upsert_model(model)
+    snapshot = context.get_snapshot(model, raise_if_missing=True)
+    customers_snapshot = context.get_snapshot("sushi.customers", raise_if_missing=True)
+    waiter_as_customer_snapshot = context.get_snapshot(
+        "sushi.waiter_as_customer_by_day", raise_if_missing=True
+    )
+
+    plan = context.plan("dev", no_prompts=True, skip_tests=True, enable_preview=True)
+
+    assert len(plan.new_snapshots) == 3
+    assert (
+        plan.context_diff.snapshots[snapshot.snapshot_id].change_category
+        == SnapshotChangeCategory.FORWARD_ONLY
+    )
+    assert (
+        plan.context_diff.snapshots[customers_snapshot.snapshot_id].change_category
+        == SnapshotChangeCategory.FORWARD_ONLY
+    )
+    assert (
+        plan.context_diff.snapshots[waiter_as_customer_snapshot.snapshot_id].change_category
+        == SnapshotChangeCategory.FORWARD_ONLY
+    )
+
+    assert plan.start == to_date("2023-01-07")
+    assert plan.missing_intervals == [
+        SnapshotIntervals(
+            snapshot_id=customers_snapshot.snapshot_id,
+            intervals=[
+                (to_timestamp("2023-01-07"), to_timestamp("2023-01-08")),
+            ],
+        ),
+        SnapshotIntervals(
+            snapshot_id=snapshot.snapshot_id,
+            intervals=[
+                (to_timestamp("2023-01-07"), to_timestamp("2023-01-08")),
+            ],
+        ),
+        SnapshotIntervals(
+            snapshot_id=waiter_as_customer_snapshot.snapshot_id,
+            intervals=[
+                (to_timestamp("2023-01-07"), to_timestamp("2023-01-08")),
+            ],
+        ),
+    ]
+
+    context.apply(plan)
+
+
 @freeze_time("2023-01-08 15:00:00")
 def test_hourly_model_with_lookback_no_backfill_in_dev(init_and_plan_context: t.Callable):
     context, plan = init_and_plan_context("examples/sushi")

tests/core/test_snapshot.py

@@ -611,6 +611,14 @@ def test_get_removal_intervals_full_history_restatement_model(make_snapshot):
     snapshot = make_snapshot(model)
     snapshot.add_interval("2020-01-01", "2024-01-01")
 
+    interval = snapshot.get_removal_interval(
+        "2023-01-01",
+        "2023-01-01",
+        execution_time=execution_time,
+        is_preview=True,
+    )
+    assert interval == (to_timestamp("2023-01-01"), execution_time)
+
     interval = snapshot.get_removal_interval(
         "2023-01-01", "2023-01-01", execution_time=execution_time
     )