Skip to content

feat(SWRDataLabLight, SWRDataLabDark): Make admin labels optional #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomephant merged 3 commits into from
Jan 22, 2026
Merged

feat(SWRDataLabLight, SWRDataLabDark): Make admin labels optional #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13abc5a
Add story
awesomephant Jan 22, 2026
b138a8e
Implement feature
awesomephant Jan 22, 2026
1b4c707
Iterate docs
awesomephant Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/src/maplibre/MapStyle/SWRDataLabDark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const style: styleFunction = (opts) => {
...(options.places?.showLabels ? placeLabels : []),

// 11. Admin boundary labels
...boundaryLabels
...(options.admin?.showLabels ? boundaryLabels : [])
]
};
};
Expand Down
7 changes: 4 additions & 3 deletions components/src/maplibre/MapStyle/SWRDataLabLight.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,14 @@ interface StyleOptions {
enableBuildingExtrusions?: boolean;
enableHillshade?: boolean;
roads?: {
showLabels?: boolean
showLabels?: boolean;
}
places?: {
showLabels?: boolean
showLabels?: boolean;
}
admin?: {
show?: boolean | []AdminLevel
show?: boolean | []AdminLevel;
showLabels: boolean;
}
}
```
Expand Down
22 changes: 22 additions & 0 deletions components/src/maplibre/MapStyle/SWRDataLabLight.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,28 @@
</div>
</DesignTokens>
</Story>
<Story asChild name="Hide admin labels">
<DesignTokens theme="light">
<div class="grid">
<div class="container">
<Map
showDebug
style={SWRDataLabLight({
admin: { show: true, showLabels: false }
})}
initialLocation={{
lng: 7.57,
lat: 49.3,
zoom: 7.66,
pitch: 0
}}
>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="fix/122">
<DesignTokens theme="light">
<div class="grid">
Expand Down
2 changes: 1 addition & 1 deletion components/src/maplibre/MapStyle/SWRDataLabLight.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ const style: styleFunction = (opts) => {
...(options.places?.showLabels ? placeLabels : []),

// 11. Admin boundary labels
...boundaryLabels
...(options.admin?.showLabels ? boundaryLabels : [])
]
};
};
Expand Down
3 changes: 2 additions & 1 deletion components/src/maplibre/MapStyle/defaultOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const opts: StyleOptions = {
showLabels: true
},
admin: {
show: true
show: true,
showLabels: true
}
};

Expand Down
1 change: 1 addition & 0 deletions components/src/maplibre/MapStyle/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ interface StyleOptions {
};
admin?: {
show?: boolean | AdminLevel[];
showLabels?: boolean;
};
roads?: {
showLabels?: boolean;
Expand Down