✨ Increase retry defaults and add visible retry logging

Author: SamPetherbridge

asa_api_client/resources/base.py

@@ -35,9 +35,9 @@
 UpdateT = TypeVar("UpdateT", bound=BaseModel)
 
 # Retry configuration
-DEFAULT_MAX_RETRIES = 3
-DEFAULT_INITIAL_DELAY = 1.0  # seconds
-DEFAULT_MAX_DELAY = 60.0  # seconds
+DEFAULT_MAX_RETRIES = 5
+DEFAULT_INITIAL_DELAY = 5.0  # seconds - Apple rate limits often need longer waits
+DEFAULT_MAX_DELAY = 120.0  # seconds
 DEFAULT_BACKOFF_FACTOR = 2.0
 RETRYABLE_STATUS_CODES = {429, 500, 502, 503, 504}
 

asa_api_client/resources/custom_reports.py

@@ -7,6 +7,7 @@
 import builtins
 import csv
 import io
+import sys
 import time
 from datetime import date
 from typing import TYPE_CHECKING, Any
@@ -196,13 +197,13 @@ def _request(
             # Check if we should retry based on status code
             if response.status_code in RETRYABLE_STATUS_CODES and attempt < max_retries:
                 delay = self._calculate_retry_delay(attempt, response)
-                logger.warning(
-                    "Received %d (attempt %d/%d), retrying in %.1fs",
-                    response.status_code,
-                    attempt + 1,
-                    max_retries + 1,
-                    delay,
+                # Log to both logger and stderr for visibility
+                msg = (
+                    f"Rate limited ({response.status_code}), "
+                    f"attempt {attempt + 1}/{max_retries + 1}, retrying in {delay:.0f}s..."
                 )
+                logger.warning(msg)
+                print(f"⏳ {msg}", file=sys.stderr)
                 time.sleep(delay)
                 continue
 
@@ -261,13 +262,12 @@ async def _request_async(
             # Check if we should retry based on status code
             if response.status_code in RETRYABLE_STATUS_CODES and attempt < max_retries:
                 delay = self._calculate_retry_delay(attempt, response)
-                logger.warning(
-                    "Received %d (attempt %d/%d), retrying in %.1fs",
-                    response.status_code,
-                    attempt + 1,
-                    max_retries + 1,
-                    delay,
+                msg = (
+                    f"Rate limited ({response.status_code}), "
+                    f"attempt {attempt + 1}/{max_retries + 1}, retrying in {delay:.0f}s..."
                 )
+                logger.warning(msg)
+                print(f"⏳ {msg}", file=sys.stderr)
                 await asyncio.sleep(delay)
                 continue
 

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "asa-api-client"
-version = "0.1.4"
+version = "0.1.5"
 description = "A modern Python client for the Apple Search Ads API with full type safety and async support"
 readme = "README.md"
 license = "MIT"