🔧 Add pre-commit hooks and fix lint issues

- Add .pre-commit-config.yaml with ruff and mypy hooks
- Fix mypy error: add type annotation to jwt.encode result
- Fix ruff formatting in custom_reports.py
- Remove invalid UP046 rule from pyproject.toml

Author: SamPetherbridge

.pre-commit-config.yaml

@@ -0,0 +1,21 @@
+repos:
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.8.3
+    hooks:
+      - id: ruff
+        args: [--fix]
+      - id: ruff-format
+
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.13.0
+    hooks:
+      - id: mypy
+        additional_dependencies:
+          - pydantic>=2.9.0
+          - pydantic-settings>=2.6.0
+          - httpx>=0.27.0
+          - pandas-stubs>=2.2.0
+          - types-requests
+        args: [--ignore-missing-imports]
+        pass_filenames: false
+        entry: mypy asa_api_client

asa_api_client/auth.py

@@ -213,7 +213,7 @@ def _generate_client_secret(self) -> str:
         }
 
         try:
-            client_secret = jwt.encode(
+            client_secret: str = jwt.encode(
                 payload,
                 self._private_key,
                 algorithm=ALGORITHM,

asa_api_client/resources/custom_reports.py

@@ -107,9 +107,7 @@ def _get_headers(self) -> dict[str, str]:
 
     async def _get_headers_async(self) -> dict[str, str]:
         """Get headers for async API requests."""
-        token = await self._client._authenticator.get_access_token_async(
-            self._async_http_client
-        )
+        token = await self._client._authenticator.get_access_token_async(self._async_http_client)
         return {
             "Authorization": token.authorization_header,
             "X-AP-Context": f"orgId={self._client.org_id}",

pyproject.toml

@@ -115,7 +115,6 @@ select = [
 ignore = [
     "D100",   # Missing docstring in public module
     "D104",   # Missing docstring in public package
-    "UP046",  # Generic class uses Generic subclass instead of type params (requires invasive changes)
 ]
 
 [tool.ruff.lint.pydocstyle]