Skip to content

time: use short relative timestamps for french (#168) #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Umbranoxio merged 1 commit into from
Jun 7, 2026
+7 −1
Merged

time: use short relative timestamps for french (#168) #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/shared/components/time.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const RELATIVE_UNITS: { seconds: number; unit: Intl.RelativeTimeFormatUnit }[] =

const LONG_SHORT_TIME_LENGTH = 11;
const MIN_SHORT_TIME_SCALE = 0.65;
const SHORT_RELATIVE_TIME_LOCALES = ['fr', 'ru'];

export function Time({ date, short, dateOnly, className, longRelativeClassName, shortFitTargetLength, minShortFitScale }: TimeProps) {
const dateObj = date == null ? null : new Date(date);
Expand Down Expand Up @@ -109,7 +110,7 @@ function timeAgo(date: Date, isShort: boolean | undefined, formatters: TimeForma
type TimeFormatters = ReturnType<typeof createTimeFormatters>;

function createTimeFormatters(locale: string) {
const shortRelativeStyle: Intl.RelativeTimeFormatStyle = locale.toLowerCase().startsWith('ru') ? 'short' : 'narrow';
const shortRelativeStyle: Intl.RelativeTimeFormatStyle = usesShortRelativeTime(locale) ? 'short' : 'narrow';

return {
relativeLong: new Intl.RelativeTimeFormat(locale, { numeric: 'always', style: 'long' }),
Expand All @@ -134,3 +135,8 @@ function createTimeFormatters(locale: string) {
})
};
}

function usesShortRelativeTime(locale: string) {
const normalizedLocale = locale.toLowerCase();
return SHORT_RELATIVE_TIME_LOCALES.some((shortLocale) => normalizedLocale === shortLocale || normalizedLocale.startsWith(`${shortLocale}-`));
}