changed setupDatabase to force sync depending on environment

If the environment is testing then the database will force sync the
database otherwise it will not force. This helps to keep the code DRY in
my opinion.

Author: ShiroTohu

source/database/setupDatabase.js

@@ -6,7 +6,7 @@ const env = process.env.NODE_ENV || 'development';
 const { logger } = require('../logger.js');
 const config = require('./config.js')[env];
 
-function setupDatabase() {
+async function setupDatabase() {
   logger.info(`Setting up ${env} Database`);
   // defaults to the devleopment database
   const sequelize = new Sequelize(
@@ -27,6 +27,14 @@ function setupDatabase() {
   Guild.hasMany(Score);
   Score.belongsTo(Guild);
 
+  // testing environment needs to be renewed each time the database is initalized as opposed to a
+  // production environment. 
+  if (env == "testing") {
+    await sequelize.sync({force: true});
+  } else {
+    await sequelize.sync();
+  }
+
   return sequelize;
 };
 

tests/helpers/testDatabase.js

@@ -3,10 +3,7 @@ const setupDatabase = require('../../source/database/setupDatabase.js');
 
 // runs the setup then returns the sequelize object to be used in tests.
 async function setupTestDatabase() {
-    const sequelize = setupDatabase();
-    await sequelize.sync();
-
-    // inserts the dummy data into the sequelize instance.
+    const sequelize = await setupDatabase(); 
     await insertDummyData(sequelize);
 
     return sequelize;

tests/insertDummyData.test.js

@@ -65,7 +65,7 @@ describe('Guild score functionality', () => {
     test('getScore method', async () => {
         const guild = await Guild.getGuild(existingGuildId);
         expect(guild.getScore(existingUserId)).resolves.toEqual(12);
-    })
+    });
 
     test('minus two', async () => {
         const guild = await Guild.getGuild(existingGuildId);