From 8a75604cd2c0cac8d995a7b06d17e64bb1798981 Mon Sep 17 00:00:00 2001 From: Alfonso Noriega Date: Tue, 23 Jun 2026 16:11:22 +0200 Subject: [PATCH] Wait an event loop turn in binary download test --- packages/app/src/cli/services/function/binaries.test.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/app/src/cli/services/function/binaries.test.ts b/packages/app/src/cli/services/function/binaries.test.ts index d6d4ffd0eac..d4d2913422d 100644 --- a/packages/app/src/cli/services/function/binaries.test.ts +++ b/packages/app/src/cli/services/function/binaries.test.ts @@ -29,6 +29,12 @@ vi.mock('@shopify/cli-kit/node/http', async () => { } }) +async function waitForNextEventLoopTurn() { + await new Promise((resolve) => { + setImmediate(resolve) + }) +} + describe('javy', () => { test('properties are set correctly', () => { expect(javy.name).toBe('javy') @@ -211,7 +217,7 @@ describe('javy', () => { const secondDownload = downloadBinary(javy).then(() => { secondResolved = true }) - await Promise.resolve() + await waitForNextEventLoopTurn() // Then — second download should be blocked waiting for first expect(secondResolved).toBe(false)