Need to catch empty inventory numbers in Product export

[SecondeJK]

Problem:

It's possible to retrieve products from the SOAP call that do no have inventory levels set, so line method inventory_quantity_for in product_exporter.rb will throw an exception on line 117 where [:result] is not set.

Steps to Reproduce:

List the steps we can take to reproduce the problem:

1. Run shopify_transporter on a Magento db where a product does not have have a SOAP response from the inventory endpoint
2. [] is called on null object - process terminates

[SecondeJK]

(I'd issue a PR for a potential solution but my Ruby is ropey, plus I don't know the consequences of doing something like returning 0 if not found in the API response)

[surajreddy]

@SecondeJK thank you for reporting this!

Does the script skip that product and continue with the others, or is it stopping entirely?

You can skip this field if it's not available. Feel free to put up a PR and we can modify it if needed.

[SecondeJK]

It doesn't skip the product, it actually terminates the script (if it skipped I wouldn't have reported it - that would be okay, but exiting Ruby when there's a big migration is obviously a bit tricky.

I can do a PR that returns 0 when it can't find a product inventory from SOAP, but I get the feeling this might have bad side effects...

[mimperatore]

@SecondeJK, there are tests in place that should help avoid regressions. Feel free to put the PR together, adding the necessary tests. We'd be happy to help you along the way to getting it merged.

[SecondeJK]

#143