fix: improve release creation with better error handling and file list building

Author: Silver-Larry

.github/workflows/build-cli.yml

@@ -63,7 +63,7 @@ jobs:
       - name: Create or Update Release
         if: github.ref == 'refs/heads/dev' || github.ref == 'refs/heads/main'
         run: |
-          set -e  # Exit on error
+          set -ex  # Exit on error, print commands
           
           VERSION="${{ steps.version.outputs.version }}"
           TAG="v${VERSION}"
@@ -84,14 +84,14 @@ jobs:
           # Copy all binary files from dist subdirectories
           echo "=== Searching for binary files ==="
           # The binaries are in dist/{platform}/bin/opencode or dist/{platform}/bin/opencode.exe
-          find packages/opencode/dist/ -type f -name "opencode" -o -name "opencode.exe" 2>/dev/null | while read -r file; do
+          find packages/opencode/dist/ -type f \( -name "opencode" -o -name "opencode.exe" \) 2>/dev/null | while read -r file; do
             echo "Found: $file"
             # Copy with platform-specific name
             platform=$(echo "$file" | sed 's|packages/opencode/dist/||' | sed 's|/bin/opencode.*||')
             if [[ "$file" == *".exe" ]]; then
-              cp "$file" "/tmp/release-assets/opencode-${platform}.exe" 2>/dev/null || echo "Failed to copy: $file"
+              cp -v "$file" "/tmp/release-assets/opencode-${platform}.exe" || echo "Failed to copy: $file"
             else
-              cp "$file" "/tmp/release-assets/opencode-${platform}" 2>/dev/null || echo "Failed to copy: $file"
+              cp -v "$file" "/tmp/release-assets/opencode-${platform}" || echo "Failed to copy: $file"
             fi
           done
           
@@ -119,20 +119,25 @@ jobs:
           
           # Check if release exists
           echo "=== Checking if release exists ==="
-          set +e
-          gh release view "$TAG" --repo ${{ github.repository }} 2>&1
-          RELEASE_EXISTS=$?
-          set -e
-          
-          if [ $RELEASE_EXISTS -ne 0 ]; then
+          if ! gh release view "$TAG" --repo ${{ github.repository }} 2>&1; then
             echo "Release $TAG does not exist, creating..."
-            # Create release with all assets - use explicit file list
+            
+            # Build file list for release
+            FILE_LIST=""
+            for f in /tmp/release-assets/*; do
+              if [ -f "$f" ]; then
+                FILE_LIST="$FILE_LIST $f"
+              fi
+            done
+            echo "Files to upload: $FILE_LIST"
+            
+            # Create release with all assets
             gh release create "$TAG" \
               --repo ${{ github.repository }} \
               --title "OpenCode CLI $TAG" \
               --prerelease \
               --generate-notes \
-              $(ls -1 /tmp/release-assets/ | sed "s|^|/tmp/release-assets/|" | tr '\n' ' ')
+              $FILE_LIST
           else
             echo "Release $TAG already exists, uploading assets..."
             # Upload assets to existing release
@@ -144,8 +149,13 @@ jobs:
             done
           fi
           
-          echo "=== Release $TAG completed ==="
-          gh release view "$TAG" --repo ${{ github.repository }} 2>&1 || echo "Failed to view release"
+          echo "=== Verifying release was created ==="
+          gh release view "$TAG" --repo ${{ github.repository }} 2>&1 || {
+            echo "ERROR: Release was not created!"
+            exit 1
+          }
+          
+          echo "=== Release $TAG completed successfully ==="
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}