[3.0]: Array to string conversion Errors

[sbulen]

Basic Information

Getting lots of Array to string conversion errors...

This line:

SMF/Sources/User.php

Line 2210 in 0106fcc

return $this->mod_cache['ap'] == [0] || array_intersect($boards, $this->mod_cache['ap']) === $boards;

Steps to reproduce

1. Navigate around the forum, browsing boards, topics, messages

Expected result

No response

Actual result

No response

Version/Git revision

3.0 Alpha 4

Database Engine

All

Database Version

8.4.4

PHP Version

8.4.5

Logs

Additional Information

No response

[sbulen]

There are actually a couple issues with that single line... I'm not 100% sure the intent here. Not gonna submit a PR, but will share what I found.

• 1... Order of operations issue, adding parens around array_intersect($boards, $this->mod_cache['ap']) === $boards gets rid of the error, but I'm not sure it's the proper solution...
• 2... Depth of multi-dim arrays being compared is different...
• 3... Not sure why it's looking at the approve posts permission at all...

In this screenshot, I'm an admin, just trying to view a board. This is what the contents of those vars look like:

[sbulen]

I just retested, & this is still an issue for new installs.