Skip to content

Commit 77f3b13

Browse files
committed
ExpressionLoader - more fixes
1 parent 93b5072 commit 77f3b13

1 file changed

Lines changed: 3 additions & 19 deletions

File tree

src/main/java/io/github/syst3ms/skriptparser/lang/entries/ExpressionLoader.java

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,13 @@
33
import io.github.syst3ms.skriptparser.file.FileElement;
44
import io.github.syst3ms.skriptparser.lang.Expression;
55
import io.github.syst3ms.skriptparser.lang.Variable;
6-
import io.github.syst3ms.skriptparser.lang.base.ConvertedExpression;
76
import io.github.syst3ms.skriptparser.log.ErrorType;
87
import io.github.syst3ms.skriptparser.log.SkriptLogger;
98
import io.github.syst3ms.skriptparser.parsing.ParserState;
109
import io.github.syst3ms.skriptparser.parsing.SyntaxParser;
1110
import io.github.syst3ms.skriptparser.types.PatternType;
12-
import io.github.syst3ms.skriptparser.types.conversions.Converters;
1311

1412
import java.util.Optional;
15-
import java.util.function.Function;
1613

1714
public class ExpressionLoader<T> extends OptionLoader {
1815

@@ -60,22 +57,9 @@ public boolean loadEntry(SectionConfiguration config, FileElement element, Parse
6057
}
6158

6259
Expression<?> expression = exprOptional.get();
63-
// This broke stuff, but I'm going to leave it just in case
64-
// if (Variable.class.isAssignableFrom(expression.getClass())) {
65-
// Class<?> returnType = expression.getReturnType();
66-
//
67-
// if (!this.typeClass.isAssignableFrom(returnType)) {
68-
// Optional<? extends Function<?, Optional<? extends T>>> converter = Converters.getConverter(returnType, this.typeClass);
69-
// if (converter.isPresent()) {
70-
// ConvertedExpression<?, T> tConvertedExpression = ConvertedExpression.newInstance(expression, this.typeClass, converter.get());
71-
// config.getData().put(this.key, tConvertedExpression);
72-
// return true;
73-
// }
74-
//
75-
// logger.error("Expression '" + s + "' does not return a " + typeClass.getSimpleName() + " found: " + expression.getReturnType().getSimpleName(), ErrorType.SEMANTIC_ERROR);
76-
// return false;
77-
// }
78-
// }
60+
if (expression instanceof Variable<?> var) {
61+
var.setReturnType(this.typeClass);
62+
}
7963

8064
config.getData().put(this.key, expression);
8165
return true;

0 commit comments

Comments
 (0)