-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
breaking changeRequires a major version bumpRequires a major version bump
Description
Lines 151 to 155 in fa3466b
| impl From<UnknownVariant> for io::Error { | |
| fn from(value: UnknownVariant) -> Self { | |
| io::Error::new(io::ErrorKind::InvalidInput, value) | |
| } | |
| } |
Seems to me that this should be InvalidData, not InvalidInput. But maybe it would be better to omit this impl entirely and have the caller do the conversion, using the appropriate ErrorKind for its specific use case.
Additionally, the type should probably be renamed to something ending in *Error, to match the convention in the standard library.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
breaking changeRequires a major version bumpRequires a major version bump