Skip to content

Not compatible with Brave 5.x #28

@b-devinssuresh-cvet

Description

@b-devinssuresh-cvet

When trying to use smartthings-brave-sqs in a sleuth app I ran into a compatibility issue:

ava.lang.NoSuchMethodError: brave.Tracer.newTrace(Lbrave/propagation/SamplingFlags;)Lbrave/Span;
	at smartthings.brave.sqs.TracingAmazonSQSClient.receiveMessage(TracingAmazonSQSClient.java:251) ~[smartthings-brave-sqs-0.5.1.jar:na]
	at com.amazon.sqs.javamessaging.AmazonSQSMessagingClientWrapper.receiveMessage(AmazonSQSMessagingClientWrapper.java:351) ~[amazon-sqs-java-messaging-lib-1.0.5.jar:na]
	at com.amazon.sqs.javamessaging.SQSMessageConsumerPrefetch.getMessages(SQSMessageConsumerPrefetch.java:262) ~[amazon-sqs-java-messaging-lib-1.0.5.jar:na]
	at com.amazon.sqs.javamessaging.SQSMessageConsumerPrefetch.run(SQSMessageConsumerPrefetch.java:221) ~[amazon-sqs-java-messaging-lib-1.0.5.jar:na]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_192]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_192]
	at java.lang.Thread.run(Thread.java:748) [na:1.8.0_192]

Are there plans to update? Or are you open to updating if I file a PR?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions