Type: tech-debt / test cleanup (not a bug)
Background
Three pkg/agent test files carry a pre-existing marker //nolint:all // Legacy test file - needs migration to new APIs. This predates the maestro-llms migration; the marker is about older agent API patterns generally.
Ask
Decide per file whether to (a) migrate it to current agent APIs and drop the //nolint:all blanket suppression (re-enabling lint), or (b) delete it if its coverage is redundant (apply the same "does anything else cover this?" analysis used for core_test.go).
These two compile and pass today, so this is non-urgent hygiene — but the blanket //nolint:all hides real lint on live test files, which is the main reason to address it rather than leave indefinitely.
Not migration-blocking; surfaced during the maestro-llms cut-over (#223). No code-behavior impact.
Type: tech-debt / test cleanup (not a bug)
Background
Three
pkg/agenttest files carry a pre-existing marker//nolint:all // Legacy test file - needs migration to new APIs. This predates the maestro-llms migration; the marker is about older agent API patterns generally.pkg/agent/core_test.go— resolved: it was also//go:build ignore(excluded from compilation) and the maestro-llms cut-over (maestro-llms cut-over: remove legacy LLM stack (−6,100 LOC, drop ollama/ollama) #223) made it reference deleted symbols. Traced every test → zero coverage lost (live targetsLLMConfig.Validate/BaseStateMachineare covered inpkg/agent/llm/api_test.goandpkg/agent/internal/core/*_test.go). Deleted in maestro-llms cut-over: remove legacy LLM stack (−6,100 LOC, drop ollama/ollama) #223.pkg/agent/validation_test.go— still active, passing. Carries the legacy marker; not build-excluded; unaffected by the migration (references no pruned symbols). The//nolint:allblanket-suppresses lint.pkg/agent/config_test.go— same as above.Ask
Decide per file whether to (a) migrate it to current agent APIs and drop the
//nolint:allblanket suppression (re-enabling lint), or (b) delete it if its coverage is redundant (apply the same "does anything else cover this?" analysis used forcore_test.go).These two compile and pass today, so this is non-urgent hygiene — but the blanket
//nolint:allhides real lint on live test files, which is the main reason to address it rather than leave indefinitely.Not migration-blocking; surfaced during the maestro-llms cut-over (#223). No code-behavior impact.