From 0d037adddbd20437700077f773c2ef997203bf67 Mon Sep 17 00:00:00 2001 From: Oleksii Kolomiiets Date: Sat, 8 Nov 2025 15:37:08 +0100 Subject: [PATCH 1/3] try to use static --- Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift | 4 ++-- Tests/SnappThemingTests/SnappThemingImageManagerTests.swift | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift b/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift index 1e373d3d3..43a447884 100644 --- a/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift +++ b/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift @@ -10,8 +10,8 @@ import SnappTheming import UniformTypeIdentifiers final class MockExternalProcessor: SnappThemingExternalImageProcessorProtocol { - let dummyImage = SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test") + static let dummyImage: SnappThemingImage? = SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test") func process(_ object: SnappTheming.SnappThemingImageObject, of type: UTType) -> SnappThemingImage? { - dummyImage + MockExternalProcessor.dummyImage } } diff --git a/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift b/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift index 9528522c2..34b63fda8 100644 --- a/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift +++ b/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift @@ -66,7 +66,7 @@ struct SnappThemingImageManagerTests { #expect(object.url == nil) #expect(object.data == dataURI.data) let image = try #require(manager.image(from: object, of: dataURI.type)) - #expect(image.size == mock.dummyImage?.size) + #expect(image.size == MockExternalProcessor.dummyImage?.size) SnappThemingImageProcessorsRegistry.shared.unregister(MockExternalProcessor.self) } From 01e4bddfaba484c1be302ac564262191b90bf9ad Mon Sep 17 00:00:00 2001 From: Oleksii Kolomiiets <70503964+oleksiikolomiietssnapp@users.noreply.github.com> Date: Sat, 8 Nov 2025 15:38:41 +0100 Subject: [PATCH 2/3] Update swift.yml --- .github/workflows/swift.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/swift.yml b/.github/workflows/swift.yml index c295e98df..e6a6b6e1b 100644 --- a/.github/workflows/swift.yml +++ b/.github/workflows/swift.yml @@ -4,7 +4,7 @@ on: push: branches: [ "main" ] pull_request: - branches: [ "main", "next" ] + branches: [ "main", "next", "feature/image-manager-tests" ] jobs: coverage: From cdbf319917bad2dc7c8f46730913cbc0183fe311 Mon Sep 17 00:00:00 2001 From: Oleksii Kolomiiets Date: Sat, 8 Nov 2025 15:45:28 +0100 Subject: [PATCH 3/3] moved dummy data --- Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift | 3 +-- Tests/SnappThemingTests/SnappThemingImageManagerTests.swift | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift b/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift index 43a447884..92dca540b 100644 --- a/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift +++ b/Tests/SnappThemingTests/Mocks/MockExternalProcessor.swift @@ -10,8 +10,7 @@ import SnappTheming import UniformTypeIdentifiers final class MockExternalProcessor: SnappThemingExternalImageProcessorProtocol { - static let dummyImage: SnappThemingImage? = SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test") func process(_ object: SnappTheming.SnappThemingImageObject, of type: UTType) -> SnappThemingImage? { - MockExternalProcessor.dummyImage + SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test") } } diff --git a/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift b/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift index 34b63fda8..c3132d811 100644 --- a/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift +++ b/Tests/SnappThemingTests/SnappThemingImageManagerTests.swift @@ -51,6 +51,7 @@ struct SnappThemingImageManagerTests { @Test func testPreparingImage_External() throws { let mock = MockExternalProcessor() + let mockImage = SnappThemingImage(systemSymbolName: "pencil", accessibilityDescription: "test") SnappThemingImageProcessorsRegistry.shared.register(mock) let manager: SnappThemingImageManager = SnappThemingImageManagerDefault( .withFileExistTrue, @@ -66,7 +67,7 @@ struct SnappThemingImageManagerTests { #expect(object.url == nil) #expect(object.data == dataURI.data) let image = try #require(manager.image(from: object, of: dataURI.type)) - #expect(image.size == MockExternalProcessor.dummyImage?.size) + #expect(image.size == mockImage?.size) SnappThemingImageProcessorsRegistry.shared.unregister(MockExternalProcessor.self) }