workstation-v0: integrate aggregate polish validation into doctor

[mdheller]

Closed by PR #142.

Resolution:

• Integrated check-workstation-polish.sh into profiles/linux-dev/workstation-v0/doctor.sh.
• Added warning-oriented doctor results for Mac polish and keyboard policy aggregate signals.
• Added .github/workflows/workstation-doctor-polish.yml to validate doctor JSON shape and warning-only behavior.
• Preserved existing doctor JSON shape and did not fail doctor solely on optional polish issues.

Validation evidence is recorded in PR #142.

[mdheller]

@codex Please take this in the SociOS-Linux/source-os Codex environment. One PR: integrate aggregate workstation polish validation into doctor.sh only. Inspect the repo first and include validation evidence. Keep scope bounded to issue #120.

[mdheller]

@copilot Please take this if available. Keep it bounded to issue #120: integrate check-workstation-polish.sh into doctor.sh only, preserve the doctor JSON shape, and open one PR with validation evidence. Do not broaden scope.

[chatgpt-codex-connector]

Summary

• Added a new check_workstation_polish() path in doctor.sh to consume bin/check-workstation-polish.sh, with warning-oriented handling when the aggregate helper is missing/fails/empty instead of introducing hard-fail behavior for this lane. profiles/linux-dev/workstation-v0/doctor.shL349-L372
• Mapped aggregate helper signals into doctor results:
  • warns when nested helper presence signals are missing (mac_polish.helper, keyboard_policy.helper);
  • treats invalid keyboard backend policy as warn;
  • records valid keyboard backend policy as ok;
  • keeps all output within existing doctor result records (no JSON shape changes). profiles/linux-dev/workstation-v0/doctor.shL374-L394
• Integrated the aggregate check into the main doctor execution flow (check_workstation_polish now runs alongside existing checks). profiles/linux-dev/workstation-v0/doctor.shL444-L450
• Committed on current branch: 9851a97 with message doctor: consume aggregate workstation polish helper.

Testing

• ✅ bash -n profiles/linux-dev/workstation-v0/doctor.sh
• ✅ SOURCEOS_PROFILE_DIR=profiles/linux-dev/workstation-v0 bash profiles/linux-dev/workstation-v0/doctor.sh --json | tee /tmp/doctor.json | python3 -c 'import json,sys; j=json.loads(sys.stdin.read()); assert j["kind"]=="sourceos.doctor"; assert j["profile"]=="linux-dev/workstation-v0"; assert "summary" in j; assert isinstance(j["results"], list); print("ok")'
• ✅ SOURCEOS_PROFILE_DIR=profiles/linux-dev/workstation-v0 SOURCEOS_REMAP_BACKEND=invalid bash profiles/linux-dev/workstation-v0/doctor.sh --json > /tmp/doctor-invalid.json || true; python3 - <<'PY' import json j=json.load(open('/tmp/doctor-invalid.json')) matches=[r for r in j['results'] if r['name']=='workstation-polish-keyboard-policy'] print(matches[-1] if matches else 'missing') print('ok field:', j['ok']) PY (confirmed warning result for invalid backend policy)

Also completed required PR creation step via make_pr with a title/body including validation evidence.

View task →

[mdheller]

@codex Follow-up verification: your task response claims commit 9851a97 and PR creation, but I cannot verify a GitHub PR, branch, or commit in this repo.

Please either open the GitHub PR against issue #120, or report what blocked PR/branch creation. Keep the same bounded scope and include validation evidence. Do not broaden scope.

[mdheller]

@copilot Verification follow-up: this issue is assigned to Copilot, but no GitHub PR, branch, or commit is visible yet. Please open one bounded PR against main for issue #120 with validation evidence, or report what is blocking PR creation. Keep scope unchanged.