Add guarded Office execution tests

Author: mdheller

tests/test_office_cli.py

@@ -31,6 +31,9 @@ def _office_args(**overrides):
         "output_root": "~/Documents/SourceOS/agent-output",
         "downloads_root": "~/Downloads/SourceOS/agent-downloads",
         "template_root": "~/dev",
+        "execute": False,
+        "policy_ok": False,
+        "evidence_out": None,
     }
     values.update(overrides)
     return _Args(**values)
@@ -77,8 +80,67 @@ def test_office_generate_dry_run_via_main(self):
         ])
         self.assertEqual(rc, 0)
 
-    def test_office_generate_no_dry_run_rejected(self):
-        args = _office_args(dry_run=False, template=None, prompt_ref=None, data_ref=None)
+    def test_office_generate_execute_requires_policy_ok(self):
+        args = _office_args(
+            execute=True,
+            policy_ok=False,
+            format="md",
+            template=None,
+            prompt_ref=None,
+            data_ref=None,
+        )
+        self.assertEqual(office.generate(args), 1)
+
+    def test_office_generate_execute_rejects_binary_formats(self):
+        with tempfile.TemporaryDirectory() as tmpdir:
+            args = _office_args(
+                execute=True,
+                policy_ok=True,
+                format="docx",
+                output_root=tmpdir,
+                template=None,
+                prompt_ref=None,
+                data_ref=None,
+            )
+            self.assertEqual(office.generate(args), 1)
+
+    def test_office_generate_execute_writes_markdown_and_evidence(self):
+        with tempfile.TemporaryDirectory() as tmpdir:
+            evidence_path = os.path.join(tmpdir, "evidence", "office.json")
+            rc = main([
+                "office",
+                "generate",
+                "--execute",
+                "--policy-ok",
+                "--artifact-type",
+                "document",
+                "--format",
+                "md",
+                "--title",
+                "Safe Report",
+                "--output-root",
+                tmpdir,
+                "--evidence-out",
+                evidence_path,
+            ])
+            self.assertEqual(rc, 0)
+            self.assertTrue(os.path.exists(os.path.join(tmpdir, "safe-report.md")))
+            with open(evidence_path, "r", encoding="utf-8") as handle:
+                evidence = json.load(handle)
+            self.assertEqual(evidence["kind"], "OfficeArtifactEvidence")
+            self.assertEqual(evidence["operation"], "generate")
+            self.assertEqual(evidence["status"], "requires-review")
+
+    def test_office_generate_execute_rejects_whole_home_output_root(self):
+        args = _office_args(
+            execute=True,
+            policy_ok=True,
+            format="md",
+            output_root="~",
+            template=None,
+            prompt_ref=None,
+            data_ref=None,
+        )
         self.assertEqual(office.generate(args), 1)
 
     def test_office_convert_dry_run_via_main(self):
@@ -91,10 +153,21 @@ def test_office_convert_dry_run_via_main(self):
         finally:
             os.unlink(tmp_path)
 
-    def test_office_convert_no_dry_run_rejected(self):
-        args = _office_args(dry_run=False, input="/tmp/example.docx", to="pdf")
+    def test_office_convert_execute_requires_policy_ok(self):
+        args = _office_args(execute=True, policy_ok=False, input="/tmp/example.docx", to="pdf")
         self.assertEqual(office.convert(args), 1)
 
+    def test_office_convert_execute_missing_input_rejected(self):
+        with tempfile.TemporaryDirectory() as tmpdir:
+            args = _office_args(
+                execute=True,
+                policy_ok=True,
+                input="/nonexistent/example.docx",
+                to="pdf",
+                output_root=tmpdir,
+            )
+            self.assertEqual(office.convert(args), 1)
+
     def test_office_inspect_valid_file(self):
         with tempfile.NamedTemporaryFile(suffix=".txt", mode="w", delete=False) as handle:
             handle.write("hello")
@@ -109,14 +182,12 @@ def test_office_inspect_missing_file(self):
 
     def test_office_evidence_inspect_valid(self):
         payload = {
-            "type": "OfficeArtifactEvidence",
-            "officeArtifact": {
-                "artifactId": "office-artifact-test",
-                "workroomId": "workroom-test",
-                "artifactType": "document",
-                "format": "docx",
-                "evidenceRefs": ["evidence://office/test"],
-            },
+            "kind": "OfficeArtifactEvidence",
+            "artifactId": "office-artifact-test",
+            "workroomId": "workroom-test",
+            "artifactType": "document",
+            "format": "docx",
+            "evidenceRefs": ["evidence://office/test"],
         }
         with tempfile.NamedTemporaryFile(suffix=".json", mode="w", delete=False) as handle:
             json.dump(payload, handle)