From 13b176e30f190280b73575ae4cd1c3ae053408d6 Mon Sep 17 00:00:00 2001
From: SpaceMolt DevTeam <devteam@spacemolt.com>
Date: Sun, 7 Jun 2026 00:59:57 -0400
Subject: [PATCH] fix: don't release when only x-gameserver-version changed in
 spec
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The server stamps info.x-gameserver-version into the OpenAPI spec on
every deploy, even when the API surface is identical. The sync workflow
detected changes with a raw file diff, so every gameserver deploy cut a
full client release — new tag, binaries, release notification, and an
update nag for every player — with zero functional difference. Six of
the seven releases since v1.4.29 were version-string-only.

Compare the specs with x-gameserver-version stripped (and keys
sort-normalized) so only real API changes trigger the release train.
Nothing in the client consumes x-gameserver-version; the tracked copy
catches up on the next real spec change.

Verified against history: v1.4.30/32/33/34/35/36 would have been
skipped; v1.4.27 and v1.4.31 (real schema changes) still release.
---
 .github/workflows/sync-spec.yml | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/sync-spec.yml b/.github/workflows/sync-spec.yml
index b194dd8..99886f9 100644
--- a/.github/workflows/sync-spec.yml
+++ b/.github/workflows/sync-spec.yml
@@ -84,8 +84,30 @@ jobs:
       - name: Diff against tracked spec
         id: diff
         run: |
-          if git diff --quiet -- openapi.json; then
-            echo "Spec is unchanged."
+          # The server stamps info.x-gameserver-version into the spec on every
+          # deploy, even when the API surface is identical. A raw file diff
+          # would therefore cut a client release for every gameserver deploy.
+          # Compare the specs with that field stripped so only real API
+          # changes trigger a release. Nothing in the client consumes
+          # x-gameserver-version, so letting it go stale in the tracked spec
+          # is harmless; it catches up on the next real change.
+          git show HEAD:openapi.json > /tmp/tracked-spec.json
+          if bun -e "
+            const fs = require('fs');
+            const sort = (x) => Array.isArray(x) ? x.map(sort)
+              : x && typeof x === 'object'
+                ? Object.fromEntries(Object.keys(x).sort().map(k => [k, sort(x[k])]))
+                : x;
+            const norm = (f) => {
+              const spec = JSON.parse(fs.readFileSync(f, 'utf-8'));
+              if (spec.info) delete spec.info['x-gameserver-version'];
+              return JSON.stringify(sort(spec));
+            };
+            process.exit(norm('/tmp/tracked-spec.json') === norm('openapi.json') ? 0 : 1);
+          "; then
+            echo "Spec is unchanged (ignoring x-gameserver-version)."
+            # Discard the version-only delta so the tree stays clean.
+            git checkout -- openapi.json
             echo "changed=false" >> "$GITHUB_OUTPUT"
           else
             echo "Spec changed."