Build fails with `error: 1 positional argument in format string, but no arguments were given` [...] `Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),`

[dreirund]

Ahoj,

building it with this recipe, build fails with

error: 1 positional argument in format string, but no arguments were given
   --> src/main.rs:532:88
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |                                                                                        ^^

More:

[...]
   Compiling egui-winit v0.27.2
   Compiling eframe v0.27.2
error: 1 positional argument in format string, but no arguments were given
   --> src/main.rs:532:88
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |                                                                                        ^^

warning: unused imports: `ImageSource` and `epaint::ColorImage`
  --> src/main.rs:12:27
   |
12 | use eframe::{egui::{self, ImageSource}, epaint::ColorImage};
   |                           ^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused variable: `error`
   --> src/main.rs:532:13
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |             ^^^^^ help: if this is intentional, prefix it with an underscore: `_error`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `pineflash` (bin "pineflash") generated 2 warnings
error: could not compile `pineflash` (bin "pineflash") due to 1 previous error; 2 warnings emitted

Regards!

[acuteaangle]

This is my bad. Introduced by gh-83, will be fixed by gh-86.

[dreirund]

Ahoj,

I still get this error, is not yet fixed in the main git repository source.

However, when I manually apply that patch called gh-86 in the message above, build succeeds.

So, you still need to apply it to the source repository.

Refards!, and P.S.:
I "only" get two warnings then:

[...]
   Compiling egui-winit v0.27.2
   Compiling eframe v0.27.2
warning: unused imports: `ImageSource` and `epaint::ColorImage`
  --> src/main.rs:12:27
   |
12 | use eframe::{egui::{self, ImageSource}, epaint::ColorImage};
   |                           ^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: constant `ICON` is never used
  --> src/main.rs:25:7
   |
25 | const ICON: &[u8] = include_bytes!("../assets/pine64logo.ico");
   |       ^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: `pineflash` (bin "pineflash") generated 2 warnings (run `cargo fix --bin "pineflash"` to apply 1 suggestion)
    Finished `release` profile [optimized] target(s) in 1m 40s

[acuteaangle]

@dreirund This is currently only blocked on @Spagett1 being available to merge the fix. They are likely not yet aware that the master build is failing.

Meanwhile, as an alternative to manually applying the patch, you could also checkout the latest release version with git checkout 0.5.5, download it from the releases page, or directly pull the patched version withgit fetch origin refs/pull/86/head:gh-86 ; git switch gh-86

[acuteaangle]

This should now be resolved by gh-86.

[Spagett1]

Should be resolved by the recent PR #86 , if the issue persists please feel free to reopen.

[dreirund]

[Off-Topic] Thanks for your advices, @acuteaangle:

Meanwhile, as an alternative to manually applying the patch, you could also checkout the latest release version with git checkout 0.5.5, download it from the releases page

I intentionally package the latest state from git,

or directly pull the patched version withgit fetch origin refs/pull/86/head:gh-86 ; git switch gh-86

For my, applying a patch is the most direct way of doing stuff. Never know what happens with all those "git magic" (might be just because I am not knowledgeable in git).

Regards!