Container's content margins not taken into account

[SamiLaakso]

When content margins are applied to the ScrollContainer using a StyleBox, the smooth scrolling no longer works properly. Here are the edits I added to make them work. I didn't make a push request as I'm still very new to Git. Feel free to implement these to help everyone using the plugin! :)

New variables:

var content_margin_top:= 0.0
var content_margin_bottom:= 0.0
var content_margin_left:= 0.0
var content_margin_right:= 0.0

_ready() (this might need some way to check if there is a style box set or not):

var style_box = get_theme_stylebox("panel")
content_margin_top = style_box.content_margin_top
content_margin_bottom = style_box.content_margin_bottom
content_margin_left = style_box.content_margin_left
content_margin_right = style_box.content_margin_right

scroll(), under 'if vertical':

content_node.position.y += content_margin_top

scroll(), under 'else' (horizontal):

content_node.position.x += content_margin_left

get_child_size_x_diff():

child_size_x += content_margin_left + content_margin_right

get_child_size_y_diff():

child_size_y += content_margin_top + content_margin_bottom

ensure_control_visible() (this replaces the last part):

if boundary_dist.x < 0 + follow_focus_margin + content_margin_left:
	# Scroll left
	scroll_x_to(content_node_position.x - boundary_dist.x + follow_focus_margin)
elif boundary_dist.y > 0 - follow_focus_margin - content_margin_right:
	# Scroll right
	scroll_x_to(content_node_position.x - boundary_dist.y - follow_focus_margin - content_margin_left - content_margin_right)
if boundary_dist.z < 0 + follow_focus_margin + content_margin_top:
	# Scroll up
	scroll_y_to(content_node_position.y - boundary_dist.z + follow_focus_margin)
elif boundary_dist.w > 0 - follow_focus_margin - content_margin_bottom:
	# Scroll down
	scroll_y_to(content_node_position.y - boundary_dist.w - follow_focus_margin - content_margin_top - content_margin_bottom)

PS. Thanks for the plugin, it is great!

[SpyrexDE]

Thanks for creating the issue! The new release of the plugin godot4-v1.3.8 will now have support for content margins. :)

[SamiLaakso]

Awesome! However, the update doesn't quite do the excepted behaviour with keyboard / controller input.

Current behaviour:
https://github.com/user-attachments/assets/0bed6a34-ab74-41e1-8b80-805d7815176b

• You cannot reach the top or bottom with keyboard
• It can scroll downwards even when it wouldn't need to do it
• I fixed this by editing the ensure_control_visible()
  • I didn't edit the latest version, but rolled back to my edits

Expected behaviour:
https://github.com/user-attachments/assets/9d691e59-c709-4c4d-8ec6-23e8b6c4ac8d

• I want to ignore the padding when doing visibility calculations (not sure if this is the same for everyone)

[SpyrexDE]

Oh you are right, I forgot to apply the content margins in the ensure_control_visible_smooth function. I just added it. Does this solve your problem?

[SamiLaakso]

There are still some oddities. For some reason, it works fine in my test scene, but not properly in my actual game. My version works just fine there too.

Odd behaviour in-game:
https://github.com/user-attachments/assets/87383427-b937-413f-a761-38d59da94b86

Proper behaviour in a test scene:
https://github.com/user-attachments/assets/c026f9df-0d10-4502-a935-711c9ca0aea0

[SpyrexDE]

Hm thats weird. Maybe you can try to create a minimal reproduciton project? Try to copy all properties of your SmoothScroll node and content node.

[SamiLaakso]

I found the culprit. If you make a simple test scene but start the game with the SmoothScrollContainer hidden, then reveal it, the margins aren't updated correctly for it to work properly. My game has the menu hidden by default.

[SamiLaakso]

The issue persists (starting the game with the SmoothScrollContainer hidden), so this should not be marked as closed.

[SpyrexDE]

Im a bit tight on time currently and might add and test a fix during the weekend but try calling _update_content_margins() after displaying the scroll container.

[SpyrexDE]

@SamiLaakso I just pushed a new commit. Can you try if it works for your project?

[SamiLaakso]

Sorry for the late reply! Now it works when the element itself starts invisible and is then set visible. However, if it starts visible inside an invisible parent and then the parent is turned visible (really common use case), it breaks similarly to how it broke before.