Refactor duplicate use Stackone API url and update tests

Author: shashi-stackone

stackone_ai/constants.py

@@ -1,3 +1,6 @@
+# StackOne API base URL
+DEFAULT_BASE_URL: str = "https://api.stackone.com"
+
 # Hybrid search default weight for BM25 vs TF-IDF
 # alpha=0.2 means: 20% BM25 + 80% TF-IDF
 # This value was optimized through validation testing and provides

stackone_ai/feedback/tool.py

@@ -6,14 +6,15 @@
 
 from pydantic import BaseModel, Field, field_validator
 
-from ..models import (
+from stackone_ai.models import (
     ExecuteConfig,
     JsonDict,
     ParameterLocation,
     StackOneError,
     StackOneTool,
     ToolParameters,
 )
+from stackone_ai.constants import DEFAULT_BASE_URL
 
 
 class FeedbackInput(BaseModel):
@@ -147,7 +148,7 @@ def execute(
 def create_feedback_tool(
     api_key: str,
     account_id: str | None = None,
-    base_url: str = "https://api.stackone.com",
+    base_url: str = DEFAULT_BASE_URL,
 ) -> FeedbackTool:
     """
     Create a feedback collection tool.

stackone_ai/semantic_search.py

@@ -59,6 +59,8 @@
 import httpx
 from pydantic import BaseModel
 
+from stackone_ai.constants import DEFAULT_BASE_URL
+
 
 class SemanticSearchError(Exception):
     """Raised when semantic search fails."""
@@ -103,7 +105,7 @@ class SemanticSearchClient:
     def __init__(
         self,
         api_key: str,
-        base_url: str = "https://api.stackone.com",
+        base_url: str = DEFAULT_BASE_URL,
         timeout: float = 30.0,
     ) -> None:
         """Initialize the semantic search client.

stackone_ai/toolset.py

@@ -25,6 +25,7 @@
     SemanticSearchError,
     SemanticSearchResult,
 )
+from stackone_ai.constants import DEFAULT_BASE_URL
 from stackone_ai.utils.normalize import _normalize_action_name
 
 logger = logging.getLogger("stackone.tools")
@@ -35,8 +36,6 @@
     _SDK_VERSION = metadata.version("stackone-ai")
 except metadata.PackageNotFoundError:  # pragma: no cover - best-effort fallback when running from source
     _SDK_VERSION = "dev"
-
-DEFAULT_BASE_URL = "https://api.stackone.com"
 _RPC_PARAMETER_LOCATIONS = {
     "action": ParameterLocation.BODY,
     "body": ParameterLocation.BODY,

tests/conftest.py

@@ -2,6 +2,12 @@
 
 from __future__ import annotations
 
+# Test base URL - used instead of production URLs in all test mocks.
+# Since respx intercepts at the HTTP client level before DNS resolution,
+# any URL string works for matching; http://localhost avoids exposing
+# real infrastructure URLs.
+TEST_BASE_URL = "http://localhost"
+
 import os
 import socket
 import subprocess

tests/test_feedback.py

@@ -12,7 +12,9 @@
 from hypothesis import given, settings
 from hypothesis import strategies as st
 
+from stackone_ai.constants import DEFAULT_BASE_URL
 from stackone_ai.feedback import create_feedback_tool
+from tests.conftest import TEST_BASE_URL
 from stackone_ai.models import StackOneError
 
 # Hypothesis strategies for PBT
@@ -48,7 +50,7 @@ class TestFeedbackToolValidation:
 
     def test_missing_required_fields(self) -> None:
         """Test validation errors for missing required fields."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="account_id"):
             tool.execute({"feedback": "Great tools!", "tool_names": ["test_tool"]})
@@ -61,7 +63,7 @@ def test_missing_required_fields(self) -> None:
 
     def test_empty_and_whitespace_validation(self) -> None:
         """Test validation for empty and whitespace-only strings."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="non-empty"):
             tool.execute({"feedback": "   ", "account_id": "acc_123456", "tool_names": ["test_tool"]})
@@ -77,7 +79,7 @@ def test_empty_and_whitespace_validation(self) -> None:
 
     def test_multiple_account_ids_validation(self) -> None:
         """Test validation with multiple account IDs."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="At least one account ID is required"):
             tool.execute({"feedback": "Great tools!", "account_id": [], "tool_names": ["test_tool"]})
@@ -87,7 +89,7 @@ def test_multiple_account_ids_validation(self) -> None:
 
     def test_invalid_account_id_type(self) -> None:
         """Test validation with invalid account ID type (not string or list)."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         # Pydantic validates input types before our custom validator runs
         with pytest.raises(StackOneError, match="(account_id|Input should be a valid)"):
@@ -100,7 +102,7 @@ def test_invalid_account_id_type(self) -> None:
 
     def test_invalid_json_input(self) -> None:
         """Test that invalid JSON input raises appropriate error."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="Invalid JSON"):
             tool.execute("not valid json {}")
@@ -112,7 +114,7 @@ def test_invalid_json_input(self) -> None:
     @settings(max_examples=50)
     def test_whitespace_feedback_validation_pbt(self, whitespace: str) -> None:
         """PBT: Test validation for various whitespace patterns in feedback."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="non-empty"):
             tool.execute({"feedback": whitespace, "account_id": "acc_123456", "tool_names": ["test_tool"]})
@@ -121,7 +123,7 @@ def test_whitespace_feedback_validation_pbt(self, whitespace: str) -> None:
     @settings(max_examples=50)
     def test_whitespace_account_id_validation_pbt(self, whitespace: str) -> None:
         """PBT: Test validation for various whitespace patterns in account_id."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="non-empty"):
             tool.execute({"feedback": "Great!", "account_id": whitespace, "tool_names": ["test_tool"]})
@@ -130,7 +132,7 @@ def test_whitespace_account_id_validation_pbt(self, whitespace: str) -> None:
     @settings(max_examples=50)
     def test_whitespace_tool_names_validation_pbt(self, whitespace_list: list[str]) -> None:
         """PBT: Test validation for lists containing only whitespace tool names."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="At least one tool name"):
             tool.execute({"feedback": "Great!", "account_id": "acc_123456", "tool_names": whitespace_list})
@@ -141,7 +143,7 @@ def test_whitespace_tool_names_validation_pbt(self, whitespace_list: list[str])
     @settings(max_examples=50)
     def test_whitespace_account_ids_list_validation_pbt(self, whitespace_list: list[str]) -> None:
         """PBT: Test validation for lists containing only whitespace account IDs."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="At least one valid account ID is required"):
             tool.execute(
@@ -156,17 +158,17 @@ def test_whitespace_account_ids_list_validation_pbt(self, whitespace_list: list[
     @settings(max_examples=50)
     def test_invalid_json_input_pbt(self, invalid_json: str) -> None:
         """PBT: Test that various invalid JSON inputs raise appropriate error."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         with pytest.raises(StackOneError, match="Invalid JSON"):
             tool.execute(invalid_json)
 
     @respx.mock
     def test_json_string_input(self) -> None:
         """Test that JSON string input is properly parsed."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
-        route = respx.post("https://api.stackone.com/ai/tool-feedback").mock(
+        route = respx.post(f"{TEST_BASE_URL}/ai/tool-feedback").mock(
             return_value=httpx.Response(200, json={"message": "Success"})
         )
 
@@ -185,10 +187,10 @@ class TestFeedbackToolExecution:
     @respx.mock
     def test_single_account_execution(self) -> None:
         """Test execution with single account ID."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
         api_response = {"message": "Feedback successfully stored", "trace_id": "test-trace-id"}
 
-        route = respx.post("https://api.stackone.com/ai/tool-feedback").mock(
+        route = respx.post(f"{TEST_BASE_URL}/ai/tool-feedback").mock(
             return_value=httpx.Response(200, json=api_response)
         )
 
@@ -213,10 +215,10 @@ def test_single_account_execution(self) -> None:
     @respx.mock
     def test_call_method_interface(self) -> None:
         """Test that the .call() method works correctly."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
         api_response = {"message": "Success", "trace_id": "test-trace-id"}
 
-        route = respx.post("https://api.stackone.com/ai/tool-feedback").mock(
+        route = respx.post(f"{TEST_BASE_URL}/ai/tool-feedback").mock(
             return_value=httpx.Response(200, json=api_response)
         )
 
@@ -234,9 +236,9 @@ def test_call_method_interface(self) -> None:
     @respx.mock
     def test_api_error_handling(self) -> None:
         """Test that API errors are handled properly."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
-        route = respx.post("https://api.stackone.com/ai/tool-feedback").mock(
+        route = respx.post(f"{TEST_BASE_URL}/ai/tool-feedback").mock(
             return_value=httpx.Response(401, json={"error": "Unauthorized"})
         )
 
@@ -255,11 +257,11 @@ def test_api_error_handling(self) -> None:
     @respx.mock
     def test_multiple_account_ids_execution(self) -> None:
         """Test execution with multiple account IDs - both success and mixed scenarios."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
         api_response = {"message": "Feedback successfully stored", "trace_id": "test-trace-id"}
 
         # Test all successful case
-        route = respx.post("https://api.stackone.com/ai/tool-feedback").mock(
+        route = respx.post(f"{TEST_BASE_URL}/ai/tool-feedback").mock(
             return_value=httpx.Response(200, json=api_response)
         )
 
@@ -302,7 +304,7 @@ def test_multiple_account_ids_execution(self) -> None:
     @respx.mock
     def test_multiple_account_ids_mixed_success(self) -> None:
         """Test execution with multiple account IDs - mixed success and error."""
-        tool = create_feedback_tool(api_key="test_key")
+        tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         def custom_side_effect(request: httpx.Request) -> httpx.Response:
             body = json.loads(request.content)
@@ -312,7 +314,7 @@ def custom_side_effect(request: httpx.Request) -> httpx.Response:
             else:
                 return httpx.Response(401, json={"error": "Unauthorized"})
 
-        route = respx.post("https://api.stackone.com/ai/tool-feedback").mock(side_effect=custom_side_effect)
+        route = respx.post(f"{TEST_BASE_URL}/ai/tool-feedback").mock(side_effect=custom_side_effect)
 
         result = tool.execute(
             {
@@ -338,7 +340,7 @@ def custom_side_effect(request: httpx.Request) -> httpx.Response:
                     "status": "error",
                     "error": (
                         "Client error '401 Unauthorized' for url "
-                        "'https://api.stackone.com/ai/tool-feedback'\n"
+                        f"'{TEST_BASE_URL}/ai/tool-feedback'\n"
                         "For more information check: "
                         "https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401"
                     ),
@@ -351,7 +353,7 @@ def custom_side_effect(request: httpx.Request) -> httpx.Response:
 
     def test_tool_integration(self) -> None:
         """Test that feedback tool integrates properly with toolset."""
-        feedback_tool = create_feedback_tool(api_key="test_key")
+        feedback_tool = create_feedback_tool(api_key="test_key", base_url=TEST_BASE_URL)
 
         assert feedback_tool is not None
         assert feedback_tool.name == "tool_feedback"
@@ -376,7 +378,7 @@ def test_live_feedback_submission() -> None:
     if not api_key:
         pytest.skip("STACKONE_API_KEY env var required for live feedback test")
 
-    base_url = os.getenv("STACKONE_BASE_URL", "https://api.stackone.com")
+    base_url = os.getenv("STACKONE_BASE_URL", DEFAULT_BASE_URL)
 
     feedback_tool = create_feedback_tool(api_key=api_key, base_url=base_url)
     assert feedback_tool is not None, "Feedback tool must be available"

tests/test_semantic_search.py

@@ -7,6 +7,7 @@
 import httpx
 import pytest
 
+from stackone_ai.constants import DEFAULT_BASE_URL
 from stackone_ai.semantic_search import (
     SemanticSearchClient,
     SemanticSearchError,
@@ -75,7 +76,7 @@ def test_init(self) -> None:
         client = SemanticSearchClient(api_key="test-key")
 
         assert client.api_key == "test-key"
-        assert client.base_url == "https://api.stackone.com"
+        assert client.base_url == DEFAULT_BASE_URL
         assert client.timeout == 30.0
 
     def test_init_custom_base_url(self) -> None: