Skip to content

buffer polyfill is used directly but not declared as a project dependency #12

Description

@abayomicornelius

src/main.tsx explicitly does import { Buffer } from 'buffer' and polyfills window.Buffer for the Stellar SDK, but buffer does not appear in package.json's dependencies — it's only present in package-lock.json as a transitive dependency (currently pulled in indirectly, likely via @stellar/stellar-sdk).

If that transitive chain ever changes (an SDK upgrade, a lockfile regeneration), the app will fail to build/run with a confusing "module not found" error. Add buffer as an explicit direct dependency to pin this intentional usage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions