🟠 [BUG] StringUtils.padRight() throws StringIndexOutOfBoundsException

[github-actions]

Description

StringUtils.padRight() throws StringIndexOutOfBoundsException when the input string is longer than the target length.

Steps to Reproduce

StringUtils.padRight("long string", 5); // throws exception

Expected Behavior

Should return the original string (or truncate) when input is longer than target length.

Files Affected

• src/main/java/com/taskflow/util/StringUtils.java (padRight method)

[github-actions]

🎯 Triage report

StringUtils.padRight() throws StringIndexOutOfBoundsException when the input string exceeds the target length because it does not guard against that case. The fix is to return the original string (or truncate) when input.length() >= targetLength.

📊 Assessment

Dimension	Value	Reasoning
Type	Bug	Reproducible exception with a provided test case.
Labels	bug	Runtime exception in utility code.
Coding agent	Suitable	Clear reproduction case; fix is a bounds check before the string operation.

🔗 Similar issues

• 🟠 [BUG] StringUtils.sanitize() is bypassable with encoded XSS payloads #8 (related) — another bug in the same StringUtils class.
• 🟠 [TECH DEBT] Replace custom StringUtils with Apache Commons Lang #17 (related) — 🟠 [TECH DEBT] Replace custom StringUtils with Apache Commons Lang #17 proposes replacing this entire class with Apache Commons Lang, which would resolve this bug as a side effect.

💡 Notes and suggestions

Consider whether the broader replacement in #17 is the better path rather than patching this class incrementally. If patching: if (str.length() >= length) return str; before the padding logic.

Generated by Daily Issue Triage · 95.1 AIC · ⌖ 18.2 AIC · ⊞ 5.4K · ◷

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/daily-issue-triage.md@1c6668b751c51af8571f01204ceffb19362e0f66

[github-actions]

🤖 This is an automated response from Test Improver.

PR #44 already contains tests that document this bug. Specifically, testPadRight_stringLongerThanWidth_throwsBug in StringUtilsTest pins the current crash behaviour with assertThrows(NegativeArraySizeException.class, ...) so any accidental regression is caught.

The fix (in StringUtils.java line ~85):

// Before (buggy):
return str + new String(new char[width - str.length()]).replace('\0', ' ');

// After (guard added):
if (str.length() >= width) return str;
return str + new String(new char[width - str.length()]).replace('\0', ' ');

Once the fix is applied, the assertThrows in the bug-pin test should be updated to assert the correct return value instead.

The triage report on this issue already notes that Issue #17 (replacing custom StringUtils with Apache Commons Lang) would resolve this as a side effect — that might be the cleaner long-term path if the broader replacement is planned.

Generated by Test Improver · 142.4 AIC · ⌖ 13.9 AIC · ⊞ 10.9K · ◷
_{Comment /test-assist to run again}

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/test-improver.md@1c6668b751c51af8571f01204ceffb19362e0f66