[FEATURE] VIP ADDING

[chycken]

Feature Summary

Hi! I have a feature request for the vip_adduser command.

I’m planning to use the Seasons plugin, which grants:

5 days of VIP at level 50

5 days of SUPERVIP at level 100

Here’s the desired behavior:

If a player who is already SUPERVIP reaches level 50 (where the plugin would normally give VIP), the system should extend their current SUPERVIP by the specified duration instead (5 days..)

If a player who is VIP reaches level 50, the system should extend their current VIP by 5 days.

If a player who is SUPERVIP reaches level 100, the system should extend their current SUPERVIP by 5 days.

If a player who is VIP reaches level 100 (where the plugin grants SUPERVIP), the system should extend their current VIP by 5 days.

In short: the plugin should never downgrade a player’s VIP level; it should only extend the existing group based on the awarded duration. Is it possible?

Why is this needed?

Additional Details (optional)

No response

[agasking1337]

Hi @chycken please can you send the link for the Seasons plugin?

[chycken]

https://github.com/K4ryuu/K4-Seasons-SwiftlyS2

[agasking1337]

@chycken that will need to be implemented into the season plugin not into the vip.

[chycken]

@agasking1337 but the seasons plugin handles only the commands, so it just runs them. Vipcore watching those thing above, it detect if a player already has vip when adding them new vip again

[agasking1337]

Still, it will need to be handled by the plugin as VIPCore allows them to give the players vip or extend the current vip. GiveClientVip

[chycken]

I understand that, but how would seasons know that the given player already has VIP?
But I think I can solve this with sql commands, in principle seasons supports that

[agasking1337]

@chycken you don't need any sql. The plugin will need to be integrated with the VIPCore API to get the player VIP.

[chycken]

@agasking1337
Unfortunately, Seasons won’t support SQL commands for a while, even though that would have been an easy way to fix this.
Seasons can run commands at different levels. Here’s an example:

"50": {
"name": "5 days VIP (BP ONLY)",
"commands": ["sw_vip_adduser {steamid} VIP 5"],
"permissions": [],
"battlePassOnly": true
},
"100": {
"name": "5 days SUPERVIP (BP ONLY)",
"commands": ["sw_vip_adduser {steamid} SUPERVIP 5"],
"permissions": [],
"battlePassOnly": true
}

So at level 50, you get 5 days of VIP, and at level 100, 5 days of SUPERVIP.

My issue is that when these commands are executed on the server by Seasons, for example at level 50, if the player already has VIP (meaning they’re already in the database because they previously purchased VIP), running this command just gives them 5 days without extending their existing VIP. In other words, even if a player who is already VIP reaches level 50, their VIP time won’t be extended by 5 days.

The main point is that we should disregard Seasons itself, because it only runs the command. What I have in mind is:

If a player is already in the database as VIP and I run sw_vip_adduser again, it should extend their current VIP by the amount specified in the command.

If the player already has a higher VIP rank than the one being added, it should extend the higher VIP group instead.

Example: If the database shows the player has 20 days left of SUPERVIP, and I run a command that gives 5 days of VIP, it should extend the SUPERVIP by 5 days, not overwrite it with regular VIP.

[agasking1337]

@chycken please try now with the latest release of vip. I have added support to extend the vip for a player if they already have vip.

[chycken]

@agasking1337 look like its working thank you!!

++"vip.Join.Permanent" and
"vip.Join.Temporary" appears in english (i know, i changed the lang in the core, only these 2 things the problem)

Just so you don’t forget: in the future it would be nice to have a flags module that works with similar logic to this one (this is compatible with Schawarper’s tags plugin):
https://github.com/SwiftlyS2-Plugins/ShopCore/tree/main/Modules/Shop_Flags

Basically, the given flag would be written into the groups, and the module would grant the player whatever flags they have assigned — but only for as long as the player is VIP, meaning they are present in the database.

CS:SH version:
https://github.com/partiusfabaa/cs2-VIPCore/tree/main/VIPCore/modules/VIP_Flags

[chycken]

@agasking1337 now a new error appeard:
VIPCore | 02/26 15:09:30 | Warning | VIPCore.VIPCore
VIPCore | [VIPCore] Cookies API Get failed.
System.Collections.Generic.KeyNotFoundException: The given key 'vip.fov' was not present in the dictionary.
at TValue System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at T Cookies.API.PlayerCookiesAPIv1.Get(long steamid, string key) in C:\Users\SkuZZi\Desktop\Cookies\Cookies\src\api\PlayerCookiesAPIv1.cs:119
at T VIPCore.Services.CookieService.GetCookie(ulong steamId, string key) in /home/runner/work/VIPCore/VIPCore/VIPCore/src/Services/CookieService.cs:66

[agasking1337]

@chycken fixed on latest release