refactor(errors): improve Google error handling type safety

- Updated error handling functions to accept `unknown` type instead of specific error types, enhancing type safety and flexibility.
- Adjusted the `handleExpressError` and `isFullSyncRequired` functions to work with the new type definitions, ensuring consistent error management across the application.
- This change improves code robustness and prepares the error handling system for a wider range of error scenarios.

Author: tyler-dane

packages/backend/src/common/errors/handlers/error.express.handler.ts

@@ -93,7 +93,7 @@ export const handleExpressError = async (
     }
 
     if (isGoogleError(e)) {
-      await handleGoogleError(req, res, userId, e);
+      await handleGoogleError(req, res, userId, e as GaxiosError);
     } else {
       const errInfo = assembleErrorInfo(e);
       res.status(e.status || Status.INTERNAL_SERVER).send(errInfo);

packages/backend/src/common/services/gcal/gcal.utils.ts

@@ -42,7 +42,7 @@ export const getEmailFromUrl = (url: string) => {
 };
 
 // occurs when token expired or revoked
-export const isInvalidGoogleToken = (e: GaxiosError | Error) => {
+export const isInvalidGoogleToken = (e: unknown) => {
   if (!isGoogleError(e)) return false;
 
   const err = e as GaxiosError;
@@ -57,9 +57,12 @@ export const isGoogleError = (e: unknown) => {
   return e instanceof GaxiosError || (e as any)?.name === "GaxiosError";
 };
 
-export const isFullSyncRequired = (e: GaxiosError | Error) => {
-  if (isGoogleError(e) && e.code) {
-    const codeStr = typeof e.code === "string" ? e.code : String(e.code);
+export const isFullSyncRequired = (e: unknown) => {
+  if (!isGoogleError(e)) return false;
+
+  const err = e as GaxiosError;
+  if (err.code) {
+    const codeStr = typeof err.code === "string" ? err.code : String(err.code);
     if (parseInt(codeStr) === 410) {
       return true;
     }

packages/backend/src/sync/controllers/sync.controller.ts

@@ -107,7 +107,7 @@ export class SyncController {
           res.status(Status.GONE).send(msg);
 
           return;
-        } else if (isFullSyncRequired(e as Error) && userId) {
+        } else if (isFullSyncRequired(e) && userId) {
           // do not await this call
           userService
             .restartGoogleCalendarSync(userId, { force: true })