[Bug] TelemetryCompilerPass ignores SYLIUS_TELEMETRY_ENABLED

[mneuville]

SyliusRefundPlugin version affected: 1.6.1

Description

SyliusRefundPlugin::build() unconditionally registers Sylius\Telemetry\TelemetryCompilerPass (from the sylius/telemetry package, v1.0.1):

public function build(ContainerBuilder $container): void
{
    parent::build($container);
    $container->addCompilerPass(new TelemetryCompilerPass());
}

That compiler pass loads every sylius.telemetry.* service (the kernel.terminate listener,
all data providers, the HTTP sender, etc.) without ever checking the SYLIUS_TELEMETRY_ENABLED
env var

Steps to reproduce

On a Sylius application with sylius/refund-plugin installed:

1. Run with telemetry explicitly enabled; the services are listed, as expected:

SYLIUS_TELEMETRY_ENABLED=1 APP_ENV=prod php bin/console debug:container sylius.telemetry.listener --env=prod --no-debug

2. Run again with telemetry explicitly disabled; the same services are still listed,
   which is the bug:

SYLIUS_TELEMETRY_ENABLED=0 APP_ENV=prod php bin/console debug:container sylius.telemetry.listener --env=prod --no-debug

3. To confirm TelemetryCompilerPass registration is the exact cause, comment out the single
   line in vendor/sylius/refund-plugin/src/SyliusRefundPlugin.php:

   final class SyliusRefundPlugin extends Bundle
   {
       use SyliusPluginTrait;

       public function build(ContainerBuilder $container): void
       {
           parent::build($container);
           // $container->addCompilerPass(new TelemetryCompilerPass());
       }
   }

4. Re-run the same command as step 2:

SYLIUS_TELEMETRY_ENABLED=0 APP_ENV=prod php bin/console debug:container sylius.telemetry.listener --env=prod --no-debug

The telemetry services are now correctly absent:
No services found that match "sylius.telemetry.listener".

Thank you for your help

[GSadee]

Hi @mneuville,

This behaviour you described is actually intentional rather than a bug. On our open-source plugins, Sylius telemetry is mandatory and is registered unconditionally by design, which is why SyliusRefundPlugin::build() always adds the TelemetryCompilerPass regardless of the SYLIUS_TELEMETRY_ENABLED environment variable.

This is documented in our Telemetry Policy. To quote it directly:

▎ While this plugin is installed and active, Sylius telemetry operates under the conditions defined by this plugin and cannot be disabled independently.

For transparency, the collected data is strictly limited to technical metadata: Sylius version, plugin version, PHP version, identifiers of installed plugins, and the environment classification. It does not include any personal data, customer information, credentials, or business/transaction data.

So the fact that the telemetry services remain registered when SYLIUS_TELEMETRY_ENABLED=0 is expected behaviour for this plugin, and not something we plan to change. Please feel free to reach out if you have any further questions about the policy or the data we collect.