Supplier-record hygiene: 609 blank-with-supplier-name parent activity_pricing rows render without policies

[Systemsaholic]

Split off from #1163 (component-policy invoice coverage) — the parent-side slice, which is a supplier-data problem, not an activity_pricing backfill.

Context

The Trip Order invoice render resolves each component's T&C as activity_pricing text → supplier default → null (coalesce at apps/api/src/financials/trip-order.service.ts:1857-1858 parent, :1927-1928 child). The supplier default is joined by free-text name: LEFT JOIN suppliers s ON s.name = ap.supplier — activity_pricing.supplier is a varchar(255) NAME, not an FK.

Gap (prod, read-only, from the #1163 diagnostic)

Of 1,163 parent components, 938 render BLANK terms, and 609 of those have a supplier NAME set on activity_pricing.supplier but the coalesce still yields blank — i.e. the name either doesn't string-match any suppliers.name row, or the matched supplier's default_terms_and_conditions is itself empty. (Cancellation: 471 parent blank.)

Because render already coalesces to the supplier default, populating/linking suppliers.default_terms_and_conditions / default_cancellation_policy (and reconciling the free-text activity_pricing.supplier names to real suppliers rows) auto-fixes the invoice for every row referencing that supplier at once — no activity_pricing write needed.

Suggested work

1. DRY report: for the 609 blank-with-supplier-name parent rows, bucket by (a) supplier name has no matching suppliers row (orphan free-text name) vs (b) matches a supplier whose default_* is empty.
2. For (b): populate the supplier defaults (Al-gated) → render self-heals.
3. For (a): reconcile the free-text names to canonical suppliers rows (the merged_into_supplier_id global/mergeable model already exists), or create supplier records with defaults.
4. Consider making activity_pricing.supplier reference suppliers.id longer-term to remove the fragile name-string join (larger change).

Notes

• This is out of scope for Backfill legacy trips' component child-policy terms (#1042 wires future imports only) #1163, which is specifically about empty child component policies (those have no supplier link and no recoverable OCR text — see the Backfill legacy trips' component child-policy terms (#1042 wires future imports only) #1163 close comment / scripts/migration/report-child-policy-coverage-1163.ts).
• No prod writes without sign-off; DRY-first.

Relates to #1163, #1042, #1161.

[Systemsaholic]

DRY bucket report (read-only, prod snapshot 2026-07-04)

Confirmed the render logic first: parent T&C = activity_pricing text || supplier default || null (trip-order.service.ts:1902-1903), supplier default joined by free-text NAME (LEFT JOIN suppliers s ON s.name = ap.supplier, :1611). So a row renders blank only when BOTH are empty.

Buckets (blank-terms PARENT rows with a supplier name set)

Bucket	Meaning	Rows	Distinct names
(a) orphan free-text name (no matching suppliers row)	ClubEG Golf Program (24) + Transat Tours Canada (1)	25	2
(b) matches a supplier whose default_terms_and_conditions is empty		601	58
Total		626	60

(626 vs the issue's 609 = data growth since filing; semantics reproduced from report-child-policy-coverage-1163.ts.)

What populating buys

• Populate default_terms_and_conditions on 58 suppliers rows → auto-fixes 601 of 626 blank rows with zero per-activity edits (render already coalesces to the supplier default). Top 5 names — Sunwing (148), Air Transat (76), G Adventures (25), Intair (24), Allianz (21) — alone cover ~294 rows.
• 56 of those 58 also have an empty default_cancellation_policy → same pass closes both fields.
• Bucket (a) 25 rows can't be fixed by editing a supplier: no suppliers row exists for ClubEG Golf Program or Transat Tours Canada. Needs a new supplier record (+ defaults) or a name-map. Transat Tours Canada likely folds into the existing Air Transat/Transat supplier.
• Name-normalization nit: TravelBrand (15) vs Travel Brand (5) are two separate free-text records — consolidate.

Next step (Al-gated)

This is now a content task, not dev: supply default_terms_and_conditions (+ default_cancellation_policy) text for the 58 suppliers (or a prioritized subset — top 5 = ~half the rows), plus 2 name reconciliations (ClubEG, Transat Tours Canada). Once the text exists, a DRY-gated write populates the supplier defaults and the invoices self-heal. No activity_pricing writes needed.

[Systemsaholic]

15-supplier batch WRITTEN (Al-approved, 2026-07-05). Ran the DRY-first empty-only populate (#1469) with --confirm: 15 default_terms_and_conditions + 14 default_cancellation_policy written (Celebrity's existing cancellation left intact). Empty-only/idempotent. Text transcribed verbatim from Al-approved drafts (grounded in each supplier's published policy). Covers 467 blank parent invoice rows across the 15 biggest suppliers. Remaining ~43 lower-volume suppliers + the 2 orphan-name rows (ClubEG Golf Program, Transat Tours Canada — no suppliers row) are a follow-up batch.