From aa87bd0d532af2dcd844d94356c80d082103c154 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 1 Oct 2022 18:24:19 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- utils/dataset.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/utils/dataset.py b/utils/dataset.py index dee3ab27..514d1d2b 100644 --- a/utils/dataset.py +++ b/utils/dataset.py @@ -372,7 +372,26 @@ def download(self): download_url(url, self.root, tar_filename, None) print('Extracting downloaded file: ' + join(self.root, tar_filename)) with tarfile.open(join(self.root, tar_filename), 'r') as tar_file: - tar_file.extractall(self.root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(tar_file, self.root) os.remove(join(self.root, tar_filename)) @staticmethod From dbafbd6a3332debb4a4a99d62d26b834959e6cf2 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 06:39:45 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- utils/dataset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/dataset.py b/utils/dataset.py index 514d1d2b..3f715e70 100644 --- a/utils/dataset.py +++ b/utils/dataset.py @@ -388,7 +388,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(tar_file, self.root)