From 405410fa23689e55e43d6702d06ba1a8998324fb Mon Sep 17 00:00:00 2001 From: mvtandas Date: Mon, 13 Apr 2026 18:51:36 +0300 Subject: [PATCH] fix(eslint-plugin-query): use TypeFlags from typescript instead of hardcoded values The `no-void-query-fn` rule used hardcoded values for `TypeFlags.Void` (16384) and `TypeFlags.Undefined` (32768). These internal TypeScript flag values were reordered in TypeScript 6 (microsoft/TypeScript#63084), causing the rule to incorrectly flag enum returns as void/undefined. Import `TypeFlags` from the `typescript` package (already a peer dependency) so the correct flag values are always used regardless of the TypeScript version. Fixes TanStack/query#10461 --- .../src/rules/no-void-query-fn/no-void-query-fn.rule.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/eslint-plugin-query/src/rules/no-void-query-fn/no-void-query-fn.rule.ts b/packages/eslint-plugin-query/src/rules/no-void-query-fn/no-void-query-fn.rule.ts index 5a8708efc0c..68a2b08eda8 100644 --- a/packages/eslint-plugin-query/src/rules/no-void-query-fn/no-void-query-fn.rule.ts +++ b/packages/eslint-plugin-query/src/rules/no-void-query-fn/no-void-query-fn.rule.ts @@ -1,15 +1,11 @@ import { ESLintUtils } from '@typescript-eslint/utils' +import { TypeFlags } from 'typescript' import { ASTUtils } from '../../utils/ast-utils' import { detectTanstackQueryImports } from '../../utils/detect-react-query-imports' import { getDocsUrl } from '../../utils/get-docs-url' import type { ParserServicesWithTypeInformation } from '@typescript-eslint/utils' import type { ExtraRuleDocs } from '../../types' -const TypeFlags = { - Void: 16384, - Undefined: 32768, -} as const - export const name = 'no-void-query-fn' const createRule = ESLintUtils.RuleCreator(getDocsUrl)