You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some standards that can be followed and code refactoring that is required.
All the branch names should follow a convention. Like lowercase with dashes or underscores or feature/featureName.
liveDataApiFormatting.test.js - Constant names can be better. For example apiToBeFormatted is the data to be formatted not the api, formatFunction is too generic.
src/handlers/liveGraph.js - The url should not be hardcoded but picked from constants. Even the port 8080 should be picked from constants.
src/utils/index.js - Coins should be in a file coin.js and not the index file. Export everything from the index file.
Remove the commented out console logs before pushing code.
Some standards that can be followed and code refactoring that is required.
All the branch names should follow a convention. Like lowercase with dashes or underscores or feature/featureName.
liveDataApiFormatting.test.js - Constant names can be better. For example apiToBeFormatted is the data to be formatted not the api, formatFunction is too generic.
src/handlers/liveGraph.js - The url should not be hardcoded but picked from constants. Even the port 8080 should be picked from constants.
src/utils/index.js - Coins should be in a file coin.js and not the index file. Export everything from the index file.
Remove the commented out console logs before pushing code.