Skip to content

Commit 0bd0f96

Browse files
author
mwmeyer
committed
Merge pull request #3 from dougiebuckets/master
tests for MMS 'get' and 'list'
2 parents 6af582b + e59ece6 commit 0bd0f96

3 files changed

Lines changed: 31 additions & 6 deletions

File tree

lib/telapi.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
require 'telapi/fraud'
1919
require 'telapi/incoming_phone_number'
2020
require 'telapi/message'
21+
require 'telapi/mms'
2122
require 'telapi/notification'
2223
require 'telapi/participant'
2324
require 'telapi/recording'

lib/telapi/mms.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ def list(optional_params = {})
1616
response = Network.get(['MMS', 'Messages'], optional_params)
1717
ResourceCollection.new(response, 'mms_messages', self)
1818
end
19-
20-
# Returns a specific Telapi::Message object given its id
19+
20+
# Returns a specific Telapi::MMS object given its id
2121
def get(id)
2222
response = Network.get(['MMS', 'Messages', id])
2323
Message.new(response)

spec/telapi/mms_spec.rb

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,34 @@
88

99
it { should be_kind_of(Telapi::Resource) }
1010

11-
describe ".create" do
12-
it "calls api via http post and returns a MMS resource" do
13-
api_should_use(:post)
14-
klass.create('(111) 111-1111', '(999) 999-9999', 'My MMS message', 'https://si0.twimg.com/profile_images/2539396551/4jsroc6lvo800o81iw64.png').should be_a(klass)
11+
describe ".list" do
12+
before { stub_telapi_request('{ "mms_messages": [] }') }
13+
14+
it "calls api via http get and returns a ResourceCollection" do
15+
api_should_use(:get)
16+
klass.list.should be_a(Telapi::ResourceCollection)
17+
end
18+
19+
context "when MMS exist" do
20+
before { stub_telapi_request('{ "mms_messages": [{ "to": "+14245551234","from": "+17325551234"}] }') }
21+
22+
it "has a collection of MMS objects" do
23+
klass.list.first.should be_a(klass)
24+
end
25+
end
26+
end
27+
28+
describe ".get" do
29+
it "calls api via http get and returns an MMS resource" do
30+
api_should_use(:get)
31+
klass.get('abc123').should be_a(klass)
1532
end
1633
end
34+
35+
describe ".create" do
36+
it "calls api via http post and returns a MMS resource" do
37+
api_should_use(:post)
38+
klass.create('(111) 111-1111', '(999) 999-9999', 'My MMS message', 'https://si0.twimg.com/profile_images/2539396551/4jsroc6lvo800o81iw64.png').should be_a(klass)
39+
end
40+
end
1741
end

0 commit comments

Comments
 (0)