Wrong `mul!` invoked.

[samuelsonric]

When I multiply two semiring matrices, this method is not being invoked.

TropicalGEMM.jl/src/gemm.jl

Line 166 in 8ee73dc

function LinearAlgebra.mul!(o::MaybeAdjOrTransMat{T}, a::MaybeAdjOrTransMat{T}, b::MaybeAdjOrTransMat{T}, α::Number, β::Number) where {T<:BlasSemiringTypes{<:NativeTypes}}

Rather, I think it is some fallback in LinearAlgebra. The library still works, but Octavian.matmul! needs to be called explicitly.

[GiggleLiu]

Any MWE? Do you use different data types for matrices? I think this dispatch only works for matrices with the same element type.

[samuelsonric]

@GiggleLiu This seems to specifically affect FixedSizeArray types (from the FixedSizeArrays.jl library).

MWE:

using TropicalNumbers, TropicalGEMM, LinearAlgebra, Octavian, FixedSizeArrays

n = 500

A = TropicalMinPlusF64.(rand(n, n))
B = TropicalMinPlusF64.(rand(n, n))
C = TropicalMinPlusF64.(rand(n, n))

fA = FixedSizeArray(A)
fB = FixedSizeArray(B)
fC = FixedSizeArray(C)

alpha = beta = one(TropicalMinPlusF64)
@time mul!(fA, fB, fC, alpha, beta);
@time matmul!(fA, fB, fC, alpha, beta);

The output is

  0.158014 seconds (1 allocation: 32 bytes)
  0.089324 seconds

[chriselrod]

TropicalGEMM.jl/src/fallbacks.jl

Lines 1 to 2 in 8ee73dc

	const ArrayOrSubArray{T,N} = Union{Array{T,N}, SubArray{T,N,<:Array}}
	const MaybeAdjOrTransMat{T} = Union{Adjoint{T,<:ArrayOrSubArray{T}}, Transpose{T,<:ArrayOrSubArray{T}}, ArrayOrSubArray{T,2}}

You can make a PR that makes these more general.