Skip to content

Commit fab20a8

Browse files
committed
fix: correct expected values in tests and add missing EOF newline
1 parent 37535bc commit fab20a8

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/main/java/com/thealgorithms/dynamicprogramming/LongestPalindromicSubsequence.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,4 @@ private static String recursiveLPS(String original, String reverse) {
3939
String sub2 = recursiveLPS(original.substring(0, original.length() - 1), reverse);
4040
return sub1.length() >= sub2.length() ? sub1 : sub2;
4141
}
42-
}
42+
}

src/test/java/com/thealgorithms/dynamicprogramming/LongestPalindromicSubsequenceTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
public class LongestPalindromicSubsequenceTest {
1111

1212
@ParameterizedTest
13-
@CsvSource({"BBABCBCAB, BABCBAB", "BABCBAB, BABCBAB", "A, A", "AA, AA", "AB, A"})
13+
@CsvSource({"BBABCBCAB, BACBCAB", "BABCBAB, BABCBAB", "A, A", "AA, AA", "AB, B"})
1414
void testLpsKnownCases(String input, String expectedLps) {
1515
assertEquals(expectedLps, LongestPalindromicSubsequence.lps(input));
1616
}
@@ -42,7 +42,7 @@ void testLpsNoRepeatingCharacters() {
4242

4343
@Test
4444
void testLpsNullThrowsException() {
45-
assertThrows(IllegalArgumentException.class, () -> LongestPalindromicSubsequence.lps(null));
45+
assertThrows(IllegalArgumentException.class, () -> { LongestPalindromicSubsequence.lps(null); });
4646
}
4747

4848
@Test
@@ -51,4 +51,4 @@ void testLpsResultIsActuallyPalindrome() {
5151
String reversed = new StringBuilder(result).reverse().toString();
5252
assertEquals(result, reversed);
5353
}
54-
}
54+
}

0 commit comments

Comments
 (0)