Fix Boyer-Moore bad character shift to use while loop

The bad_character_heuristic method was reassigning the for-loop variable
'i' inside a for loop, which has no effect in Python. This caused the
bad character shift to be ignored, making the algorithm behave as O(nm)
brute-force instead of O(n/m).

Fix: Replace for loop with while loop to allow the shift to take effect.

Fixes #14844

Author: PrinceRaymondPaul911

strings/boyer_moore_search.py

@@ -86,15 +86,15 @@ def bad_character_heuristic(self) -> list[int]:
         """
 
         positions = []
-        for i in range(self.textLen - self.patLen + 1):
+        i = 0
+        while i <= self.textLen - self.patLen:
             mismatch_index = self.mismatch_in_text(i)
             if mismatch_index == -1:
                 positions.append(i)
+                i += 1
             else:
                 match_index = self.match_in_pattern(self.text[mismatch_index])
-                i = (
-                    mismatch_index - match_index
-                )  # shifting index lgtm [py/multiple-definition]
+                i = max(i + 1, mismatch_index - match_index)
         return positions