Version 0.4

* Added start on boot option to settings menu
* Allowed the files in the /opt/ directory to be managed by the package manager
* Cleaned a bit of the code
* Updated readme instructions

Author: TheOneMaster

README.md

@@ -4,7 +4,7 @@ A fairly simple GTK tool built to mimic the basic functionality of ThrottleStop
 
 Uses <a href="https://github.com/kitsunyan/intel-undervolt">intel-undervolt</a> to perform the undervolting, therefore it must be installed on the user's system. <a href="https://github.com/kitsunyan/intel-undervolt/blob/master/README.md">The guide to installing it can be found here</a>
 
-To run this program, download the deb file from the latest <a href="https://github.com/TheOneMaster/linux-undervolt/releases/latest">release</a> and install it to the user's system. Once installed, it can be run either using the command line call `linux_undervolt` or finding the application in the application launcher (Currently it uses a placeholder icon from gnome).
+To run this program, download the deb file from the latest <a href="https://github.com/TheOneMaster/linux-undervolt/releases/latest">release</a> and install it to the user's system. Once installed, it can be run either using the command line call `linux-undervolt` or finding the application in the application launcher (Currently it uses a placeholder icon from gnome).
 
 ## GUI Instructions
 

linux_undervolt/GUI.glade

@@ -124,6 +124,16 @@
                         <property name="use-underline">True</property>
                       </object>
                     </child>
+                    <child>
+                      <object class="GtkCheckMenuItem" id="startup_menu_item">
+                        <property name="visible">True</property>
+                        <property name="can-focus">False</property>
+                        <property name="label" translatable="yes">Start on Boot</property>
+                        <property name="use-underline">True</property>
+                        <property name="draw-as-radio">True</property>
+                        <signal name="toggled" handler="startupChange" swapped="no"/>
+                      </object>
+                    </child>
                   </object>
                 </child>
               </object>
@@ -788,6 +798,9 @@
                     <property name="position">1</property>
                   </packing>
                 </child>
+                <style>
+                  <class name="inset-box"/>
+                </style>
               </object>
               <packing>
                 <property name="left-attach">1</property>

linux_undervolt/__init__.py

@@ -1 +1 @@
-__version__ = "0.3-2"
+__version__ = "0.4-1"

linux_undervolt/__main__.py

@@ -49,9 +49,7 @@ def __init__(self):
         self.builder.connect_signals(self)
 
         # Initial setup
-        self.scaleChange()
-        self.powerSwitch()
-        self.getPowerProfiles()
+        self.__initialSetup__()
 
         Notify.init("Linux Undervolt Tool")
 
@@ -100,7 +98,18 @@ def firstTimeSetup(self) -> gtk.ResponseType:
     # UI Changes #
     ##############
 
-    def scaleChange(self):
+    def __initialSetup__(self):
+        """
+        Initial UI Settings to be loaded when the app is starting. Reads config options from config file
+        and applies them to the various widgets.
+        """
+
+        self.__scaleChange__()
+        self.__getPowerProfiles__()
+        self.__powerSwitch__()
+        self.__startupMenuItem__()
+
+    def __scaleChange__(self):
         """
         Changes the scale values to the current profile values.
         """
@@ -119,7 +128,7 @@ def scaleChange(self):
         save_button = self.builder.get_object("save_button")
         save_button.set_label("Save")
 
-    def getPowerProfiles(self):
+    def __getPowerProfiles__(self):
         """
         Change power profile dropdowns to settings value.
         """
@@ -145,7 +154,7 @@ def getPowerProfiles(self):
             ac_profile_dropdown.set_active(ac_profile)
             ac_profile_check.set_active(True)
 
-    def powerSwitch(self):
+    def __powerSwitch__(self):
         """
         Activate or deactivate the power profile options according to settings.
         """
@@ -160,6 +169,13 @@ def powerSwitch(self):
             cur_obj = self.builder.get_object(object)
             cur_obj.set_sensitive(active)
 
+    def __startupMenuItem__(self):
+
+        active = self.config._parser.getboolean('SETTINGS', 'startup')
+        item = self.builder.get_object("startup_menu_item")
+
+        item.set_active(active)
+
     def onSliderChange(self, widget):
         """
         Changes the save button to be italicised when changes are made to the undervolt values.
@@ -173,6 +189,14 @@ def onSliderChange(self, widget):
     # Config Functions #
     ####################
 
+    def startupChange(self, widget):
+
+        startup_value = 1 if widget.get_active() else 0
+
+        self.config.changeSettings('startup', str(startup_value))
+        backend.startupChange(startup_value)
+            
+
     def powerProfileActivate(self, _, state):
         """
         docstring
@@ -188,7 +212,7 @@ def powerProfileActivate(self, _, state):
                 return        
 
         self.config.changeSettings('battery_switch', state_str)
-        self.powerSwitch()
+        self.__powerSwitch__()
 
     def changeProfile(self, widget):
         """
@@ -204,7 +228,7 @@ def changeProfile(self, widget):
                 self.config.changeSettings('profile', new_profile)
                 break
 
-        self.scaleChange()
+        self.__scaleChange__()
 
     def setPowerProfile(self, _):
         """

linux_undervolt/backend.py

@@ -104,3 +104,17 @@ def createBackup() -> None:
     zip_file = os.path.join(CONFIG_DIR, 'intel-undervolt.bak.zip')
     with zipfile.ZipFile(zip_file, 'w') as backup_archive:
         backup_archive.write(undervolt_file, 'intel-undervolt.conf')
+
+def startupChange(value: int) -> None:
+    """
+    Set the startup behaviour for the undervolt. If on, the undervolt is applied on boot.
+    Should only be called after the undervolt settings have been tested by the user.
+    """
+    key = {
+        0: "stop",
+        1: "start"
+    }
+
+    command = f"pkexec systemctl {key[value]} intel-undervolt"
+    run = subprocess.run(command, shell=True, stdout=subprocess.DEVNULL)
+    return run.returncode

linux_undervolt/config.py

@@ -42,7 +42,8 @@ def _createConfig(self) -> None:
             'undervolt_path': "/etc/intel-undervolt.conf",
             'battery_switch': 'false',
             'battery_profile': "",
-            'ac_profile': ""
+            'ac_profile': "",
+            'startup': 0
         }
 
         profile_options = ['cpu', 'gpu', 'cpu_cache', 'sys_agent', 'analog_io']

linux_undervolt/powersave.sh

@@ -1,10 +1,5 @@
 #!/bin/bash
 
-# Copy Python files to opt directory
-SCRIPT_PATH=$(dirname $(realpath -s $0))
-
-cp "${SCRIPT_PATH}/config.py" "/opt/linux-undervolt/"
-
 # Move temp service to Systemd services
 mv "${1}/temp.service" "/etc/systemd/system/linux-undervolt.powersave.service"
 mv "${1}/temp.env" "/etc/systemd/system/linux-undervolt.powersave.env"

setup.py

@@ -6,7 +6,7 @@
 
 
 setup(
-    name = "linux_undervolt-tool",
+    name = "linux-undervolt-tool",
     version = linux_undervolt.__version__,
     author = "TheOneMaster",
     author_email = "tmp@gmail.com",
@@ -21,7 +21,8 @@
         'gui_scripts': ["linux-undervolt = linux_undervolt.__main__:main"]
     },
     data_files=[
-        ('share/applications/', ['theonemaster-linux_undervolt.desktop'])
+        ('share/applications/', ['theonemaster-linux_undervolt.desktop']),
+        ('/opt/linux-undervolt', ['linux_undervolt/config.py'])
     ],
     classifiers=[
         "License :: OSI Approved :: GPLv2 License"

theonemaster-linux_undervolt.desktop

@@ -1,10 +1,10 @@
 [Desktop Entry]
 Name=Linux Undervolt Tool
-Version=0.3-2
+Version=0.4-1
 Type=Application
 Comment=GUI Interface for intel-undervolt
 
-Exec=linux_undervolt
+Exec=linux-undervolt
 Icon=/usr/share/icons/gnome/48x48/apps/file-manager.png
 Categories=Utility;
 

uninstall.sh

@@ -0,0 +1,4 @@
+#!/bin/bash
+
+# Remove the Udev rule from the system if it was created. 
+python3 -c "from linux_undervolt import backend; backend.removeUdevRule()"