Deadlock in MilesAudioManager::releaseMilesHandles

[xezon]

Main Thread

 	ntdll.dll!_NtWaitForSingleObject@12()	Unknown	Non-user code. Symbols loaded without source information.
 	KernelBase.dll!WaitForSingleObjectEx()	Unknown	Non-user code. Symbols loaded without source information.
 	KernelBase.dll!_WaitForSingleObject@8()	Unknown	Non-user code. Symbols loaded without source information.
 	mss32.dll!2110df4a()	Unknown	Non-user code. Binary was not built with debug information.
 	[Frames below may be incorrect and/or missing, no symbols loaded for mss32.dll]		Annotated Frame
>	generalszh.exe!MilesAudioManager::releaseMilesHandles(PlayingAudio * release) Line 994	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::loadFileForRead(AudioEventRTS * eventToLoadFrom) Line 960	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::playSample3D(AudioEventRTS * event, h3DPOBJECT * sample3D) Line 2681	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::playAudioEvent(AudioRequest * req) Line 741	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::processRequest(AudioRequest * req) Line 2805	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::processRequestList() Line 2138	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::update() Line 459	C++	Symbols loaded.
 	generalszh.exe!SubsystemInterface::UPDATE() Line 73	C++	Symbols loaded.
 	generalszh.exe!GameEngine::update() Line 909	C++	Symbols loaded.
 	generalszh.exe!Win32GameEngine::update() Line 91	C++	Symbols loaded.
 	generalszh.exe!GameEngine::execute() Line 983	C++	Symbols loaded.
 	generalszh.exe!GameMain() Line 55	C++	Symbols loaded.
 	generalszh.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Line 929	C++	Symbols loaded.
 	generalszh.exe!invoke_main() Line 107	C++	Non-user code. Symbols loaded.
 	generalszh.exe!__scrt_common_main_seh() Line 288	C++	Non-user code. Symbols loaded.
 	generalszh.exe!__scrt_common_main() Line 331	C++	Non-user code. Symbols loaded.
 	generalszh.exe!WinMainCRTStartup(void * __formal) Line 17	C++	Non-user code. Symbols loaded.
 	kernel32.dll!761a5d49()	Unknown	Non-user code. Cannot find or open the PDB file.
 	ntdll.dll!___RtlUserThreadStart@8()	Unknown	Non-user code. Symbols loaded without source information.
 	ntdll.dll!__RtlUserThreadStart@8()	Unknown	Non-user code. Symbols loaded without source information.

MSS Timer Thread

 	ntdll.dll!_NtWaitForSingleObject@12()	Unknown	Non-user code. Symbols loaded without source information.
 	KernelBase.dll!WaitForSingleObjectEx()	Unknown	Non-user code. Symbols loaded without source information.
 	KernelBase.dll!_WaitForSingleObject@8()	Unknown	Non-user code. Symbols loaded without source information.
 	generalszh.exe!ScopedMutex::ScopedMutex(void * mutex) Line 34	C++	Symbols loaded.
>	generalszh.exe!AudioFileCache::closeFile(void * fileToClose) Line 3087	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::closeFile(void * fileRead) Line 965	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::startNextLoop(PlayingAudio * looping) Line 2604	C++	Symbols loaded.
 	generalszh.exe!MilesAudioManager::notifyOfAudioCompletion(unsigned int handle, unsigned int flags) Line 1456	C++	Symbols loaded.
 	generalszh.exe!set3DSampleCompleted(h3DPOBJECT * sample3DCompleted) Line 2916	C++	Symbols loaded.
 	msssoft.m3d!22403493()	Unknown	Non-user code. Binary was not built with debug information.
 	[Frames below may be incorrect and/or missing, no symbols loaded for msssoft.m3d]		Annotated Frame
 	mss32.dll!21116124()	Unknown	Non-user code. Binary was not built with debug information.
 	mss32.dll!2111146c()	Unknown	Non-user code. Binary was not built with debug information.
 	mss32.dll!211113ad()	Unknown	Non-user code. Binary was not built with debug information.
 	mss32.dll!2110152c()	Unknown	Non-user code. Binary was not built with debug information.
 	mss32.dll!2110161d()	Unknown	Non-user code. Binary was not built with debug information.
 	kernel32.dll!761a5d49()	Unknown	Non-user code. Cannot find or open the PDB file.
 	ntdll.dll!___RtlUserThreadStart@8()	Unknown	Non-user code. Symbols loaded without source information.
 	ntdll.dll!__RtlUserThreadStart@8()	Unknown	Non-user code. Symbols loaded without source information.

[xezon]

The problem looks to be:

In AudioFileCache::openFile it locks AudioFileCache::m_mutex before calling into Miles taking its lock. And in MilesAudioManager::startNextLoop it has the Miles lock before taking the AudioFileCache::m_mutex lock : Deadlock

[xezon]

I think we need to decouple the miles calls from m_mutex locking in class AudioFileCache. Then it should work alright.