In some places in the code base the order of constructor member initializer lists is incorrect. Clang-Tidy should be very useful for this.
Example:
|
JetAwaitingRunwayState( StateMachine *machine, Bool landing ) : m_landing(landing), State( machine, "JetAwaitingRunwayState") { } |
The initialization of the base class is ordered after the member variable, even though the actual initialization ignores this.
It's best to keep the scope of this task to just the initializer list itself and not the constructor body as well, because that's a huge task in itself.
In some places in the code base the order of constructor member initializer lists is incorrect. Clang-Tidy should be very useful for this.
Example:
GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/JetAIUpdate.cpp
Line 210 in 27423a4
The initialization of the base class is ordered after the member variable, even though the actual initialization ignores this.
It's best to keep the scope of this task to just the initializer list itself and not the constructor body as well, because that's a huge task in itself.