Commit 35ce3bf
fix(mcp-store): make Install gating opt-in — only block on a hard test failure
The previous PR (`920735f`) gated Install on a successful Test
connection, mirroring the wizard's Step 3 gate. Wrong call for the
store: catalog templates ship with curated URLs and the backend's
`install_template` already runs its own probe + rejects on hard
failure, so a forced test before Install is just friction — for
public/no-auth templates like AWS Documentation it adds an extra
click for zero validation benefit.
New gating logic on the Install button:
- No test result yet → enabled (the common path)
- Test passed (`success` true) → enabled
- Test soft-success (`requires_auth` true, OAuth/PAT) → enabled
- Test hard-failed → disabled, with a tooltip explaining why
(saves the user one round-trip we know would 400)
Test connection stays as an optional preview that surfaces the
upstream's tool list before commit, useful for unfamiliar templates.
The /servers wizard's Step 3 gate is unchanged — there the URL is
typed by the operator, so the test result is the *only* thing
validating the input.
i18n: dropped `mcpServers.mustTestFirst` from the store install
tooltip (it was wrong even before — that string is the wizard's
contract). New `mcpStore.installBlockedByTestFailure` describes the
narrow case where Install is actually disabled.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent c73f7d0 commit 35ce3bf
3 files changed
Lines changed: 20 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
143 | 144 | | |
144 | 145 | | |
145 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
143 | 144 | | |
144 | 145 | | |
145 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
553 | 553 | | |
554 | 554 | | |
555 | 555 | | |
556 | | - | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
557 | 570 | | |
558 | | - | |
559 | | - | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
560 | 575 | | |
561 | 576 | | |
562 | 577 | | |
| |||
0 commit comments