forked from Rowl1ng/implicit-hyper-opt
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
I've discovered at least one cause of discrepancy between our master and Lorraine's:
https://github.com/ThrunGroup/implicit-hyper-opt/blob/master/data_loaders.py#L75-L81
Somehow, when we changed train_data to data and train_labels to targets, this results in different behavior.
Additionally, it's not clear to me why num_train is used for the val set as well
I'm also not sure why changing those field names leads to different behavior
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels