Skip to content

fit guess amplitude values when binning=True #65

@cjperks7

Description

@cjperks7

When binning=False, it was pretty straightforward to choose guess values for background and amplitude bounds and guess values just looking at the y-values when plotting the data.

When binning=True, the user now has to interpret these values as an amplitude per bin, so when choosing guess values they take the y-value and divide by the bin width. But I'm giving spectrally a wavelength vector that's not uniform (it's technically the inverse of a uniform energy vector) which it's handling just fine. But since my bin width therefore changes it's not as intuitive to me what to take as the bin width, particularly for the background.

In general, this seems to be a can of worms that might repeatedly come up with new users so maybe harmonizing with the way picking bounds/initial guess for amplitudes when binning=False, keeping the rest under the hood.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions